Skip to content
This repository was archived by the owner on Dec 6, 2019. It is now read-only.

Conversation

@gogume
Copy link

@gogume gogume commented Feb 12, 2013

ZendGData\App::performHttpRequest, loose the headers already set in the http client request object.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move open braces inline with the if/foreach statement. ZF2 follows PSR-2 Coding Style

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md

@pixiebox
Copy link

Pull pull pull!!!! Sweeeeeet.... have been looking for 2 days and it ain't pulled yet, give em an *sswhooping Cornel Les

@gogume
Copy link
Author

gogume commented Apr 29, 2013

Thanks pixiebox, but I think they have greater issues on their hands, cause this pull requests is from 3 months ago and accept Marks3w, which replied me the day I made the pull request and asked me to make code PSR-2 compliant, no one else was interested in it.
Or maybe they lack of people reviewing pull requests.

@weierophinney
Copy link
Member

Actually, it's more a case that this repo is deprecated, as it uses a
deprecated api that Google plans to retire. Fixes on it are not a priority.
On Apr 29, 2013 1:21 AM, "gogume" [email protected] wrote:

Thanks pixiebox, but I think they have greater issues on their hands,
cause this pull requests is from 3 months ago and accept Marks3w, which
replied me the day I made the pull request and asked me to make code PSR-2
compliant, no one else was interested in it.
Or maybe they lack of people reviewing pull requests.


Reply to this email directly or view it on GitHubhttps://github.com//pull/10#issuecomment-17151601
.

@gogume
Copy link
Author

gogume commented Apr 29, 2013

Here you go pixiebox, you got your answer.

Thank you weierophinney.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants