Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit 152cb1e

Browse files
committed
Optimize PHP function calls
Those optimizations target improving OPCODES.
1 parent 7afbd2e commit 152cb1e

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

src/ServiceManager.php

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,12 @@ public function configure(array $config)
323323

324324
if (! empty($aliases)) {
325325
$config['aliases'] = (isset($config['aliases']))
326-
? array_merge($config['aliases'], $aliases)
326+
? \array_merge($config['aliases'], $aliases)
327327
: $aliases;
328328
}
329329

330330
$config['factories'] = (isset($config['factories']))
331-
? array_merge($config['factories'], $factories)
331+
? \array_merge($config['factories'], $factories)
332332
: $factories;
333333
}
334334

@@ -337,7 +337,7 @@ public function configure(array $config)
337337
}
338338

339339
if (isset($config['delegators'])) {
340-
$this->delegators = array_merge_recursive($this->delegators, $config['delegators']);
340+
$this->delegators = \array_merge_recursive($this->delegators, $config['delegators']);
341341
}
342342

343343
if (isset($config['shared'])) {
@@ -357,7 +357,7 @@ public function configure(array $config)
357357
// If lazy service configuration was provided, reset the lazy services
358358
// delegator factory.
359359
if (isset($config['lazy_services']) && ! empty($config['lazy_services'])) {
360-
$this->lazyServices = array_merge_recursive($this->lazyServices, $config['lazy_services']);
360+
$this->lazyServices = \array_merge_recursive($this->lazyServices, $config['lazy_services']);
361361
$this->lazyServicesDelegator = null;
362362
}
363363

@@ -516,7 +516,7 @@ public function setShared($name, $flag)
516516
private function resolveAbstractFactories(array $abstractFactories)
517517
{
518518
foreach ($abstractFactories as $abstractFactory) {
519-
if (is_string($abstractFactory) && class_exists($abstractFactory)) {
519+
if (\is_string($abstractFactory) && \class_exists($abstractFactory)) {
520520
//Cached string
521521
if (! isset($this->cachedAbstractFactories[$abstractFactory])) {
522522
$this->cachedAbstractFactories[$abstractFactory] = new $abstractFactory();
@@ -526,15 +526,15 @@ private function resolveAbstractFactories(array $abstractFactories)
526526
}
527527

528528
if ($abstractFactory instanceof Factory\AbstractFactoryInterface) {
529-
$abstractFactoryObjHash = spl_object_hash($abstractFactory);
529+
$abstractFactoryObjHash = \spl_object_hash($abstractFactory);
530530
$this->abstractFactories[$abstractFactoryObjHash] = $abstractFactory;
531531
continue;
532532
}
533533

534534
// Error condition; let's find out why.
535535

536536
// If we still have a string, we have a class name that does not resolve
537-
if (is_string($abstractFactory)) {
537+
if (\is_string($abstractFactory)) {
538538
throw new InvalidArgumentException(
539539
sprintf(
540540
'An invalid abstract factory was registered; resolved to class "%s" ' .
@@ -568,18 +568,18 @@ private function resolveAbstractFactories(array $abstractFactories)
568568
private function resolveInitializers(array $initializers)
569569
{
570570
foreach ($initializers as $initializer) {
571-
if (is_string($initializer) && class_exists($initializer)) {
571+
if (\is_string($initializer) && \class_exists($initializer)) {
572572
$initializer = new $initializer();
573573
}
574574

575-
if (is_callable($initializer)) {
575+
if (\is_callable($initializer)) {
576576
$this->initializers[] = $initializer;
577577
continue;
578578
}
579579

580580
// Error condition; let's find out why.
581581

582-
if (is_string($initializer)) {
582+
if (\is_string($initializer)) {
583583
throw new InvalidArgumentException(
584584
sprintf(
585585
'An invalid initializer was registered; resolved to class or function "%s" ' .
@@ -659,12 +659,12 @@ private function getFactory($name)
659659
$factory = isset($this->factories[$name]) ? $this->factories[$name] : null;
660660

661661
$lazyLoaded = false;
662-
if (is_string($factory) && class_exists($factory)) {
662+
if (\is_string($factory) && \class_exists($factory)) {
663663
$factory = new $factory();
664664
$lazyLoaded = true;
665665
}
666666

667-
if (is_callable($factory)) {
667+
if (\is_callable($factory)) {
668668
if ($lazyLoaded) {
669669
$this->factories[$name] = $factory;
670670
}
@@ -704,12 +704,12 @@ private function createDelegatorFromName($name, array $options = null)
704704
$delegatorFactory = $this->createLazyServiceDelegatorFactory();
705705
}
706706

707-
if (is_string($delegatorFactory) && class_exists($delegatorFactory)) {
707+
if (\is_string($delegatorFactory) && \class_exists($delegatorFactory)) {
708708
$delegatorFactory = new $delegatorFactory();
709709
}
710710

711-
if (! is_callable($delegatorFactory)) {
712-
if (is_string($delegatorFactory)) {
711+
if (! \is_callable($delegatorFactory)) {
712+
if (\is_string($delegatorFactory)) {
713713
throw new ServiceNotCreatedException(sprintf(
714714
'An invalid delegator factory was registered; resolved to class or function "%s" '
715715
. 'which does not exist; please provide a valid function name or class name resolving '
@@ -814,7 +814,7 @@ private function createLazyServiceDelegatorFactory()
814814
));
815815
}
816816

817-
spl_autoload_register($factoryConfig->getProxyAutoloader());
817+
\spl_autoload_register($factoryConfig->getProxyAutoloader());
818818

819819
$this->lazyServicesDelegator = new Proxy\LazyServiceFactory(
820820
new LazyLoadingValueHolderFactory($factoryConfig),
@@ -892,31 +892,31 @@ private function validateOverrides(array $config)
892892
}
893893

894894
if (isset($config['services'])) {
895-
$this->validateOverrideSet(array_keys($config['services']), 'service');
895+
$this->validateOverrideSet(\array_keys($config['services']), 'service');
896896
}
897897

898898
if (isset($config['aliases'])) {
899-
$this->validateOverrideSet(array_keys($config['aliases']), 'alias');
899+
$this->validateOverrideSet(\array_keys($config['aliases']), 'alias');
900900
}
901901

902902
if (isset($config['invokables'])) {
903-
$this->validateOverrideSet(array_keys($config['invokables']), 'invokable class');
903+
$this->validateOverrideSet(\array_keys($config['invokables']), 'invokable class');
904904
}
905905

906906
if (isset($config['factories'])) {
907-
$this->validateOverrideSet(array_keys($config['factories']), 'factory');
907+
$this->validateOverrideSet(\array_keys($config['factories']), 'factory');
908908
}
909909

910910
if (isset($config['delegators'])) {
911-
$this->validateOverrideSet(array_keys($config['delegators']), 'delegator');
911+
$this->validateOverrideSet(\array_keys($config['delegators']), 'delegator');
912912
}
913913

914914
if (isset($config['shared'])) {
915-
$this->validateOverrideSet(array_keys($config['shared']), 'sharing rule');
915+
$this->validateOverrideSet(\array_keys($config['shared']), 'sharing rule');
916916
}
917917

918918
if (isset($config['lazy_services']['class_map'])) {
919-
$this->validateOverrideSet(array_keys($config['lazy_services']['class_map']), 'lazy service');
919+
$this->validateOverrideSet(\array_keys($config['lazy_services']['class_map']), 'lazy service');
920920
}
921921
}
922922

0 commit comments

Comments
 (0)