Optimize more PHP function calls and issets

Author: smuggli

src/AbstractFactory/ConfigAbstractFactory.php

@@ -21,13 +21,13 @@ final class ConfigAbstractFactory implements AbstractFactoryInterface
      */
     public function canCreate(\Interop\Container\ContainerInterface $container, $requestedName)
     {
-        if (! $container->has('config') || ! array_key_exists(self::class, $container->get('config'))) {
+        if (! $container->has('config') || ! \array_key_exists(self::class, $container->get('config'))) {
             return false;
         }
         $config = $container->get('config');
         $dependencies = $config[self::class];
 
-        return is_array($dependencies) && array_key_exists($requestedName, $dependencies);
+        return \is_array($dependencies) && \array_key_exists($requestedName, $dependencies);
     }
 
     /**
@@ -41,31 +41,31 @@ public function __invoke(\Interop\Container\ContainerInterface $container, $requ
 
         $config = $container->get('config');
 
-        if (! (is_array($config) || $config instanceof ArrayObject)) {
+        if (! (\is_array($config) || $config instanceof ArrayObject)) {
             throw new ServiceNotCreatedException('Config must be an array or an instance of ArrayObject');
         }
 
-        if (! array_key_exists(self::class, $config)) {
+        if (! \array_key_exists(self::class, $config)) {
             throw new ServiceNotCreatedException('Cannot find a `' . self::class . '` key in the config array');
         }
 
         $dependencies = $config[self::class];
 
-        if (! is_array($dependencies)
-            || ! array_key_exists($requestedName, $dependencies)
-            || ! is_array($dependencies[$requestedName])
+        if (! \is_array($dependencies)
+            || ! \array_key_exists($requestedName, $dependencies)
+            || ! \is_array($dependencies[$requestedName])
         ) {
             throw new ServiceNotCreatedException('Dependencies config must exist and be an array');
         }
 
         $serviceDependencies = $dependencies[$requestedName];
 
-        if ($serviceDependencies !== array_values(array_map('strval', $serviceDependencies))) {
-            $problem = json_encode(array_map('gettype', $serviceDependencies));
+        if ($serviceDependencies !== \array_values(\array_map('strval', $serviceDependencies))) {
+            $problem = \json_encode(\array_map('gettype', $serviceDependencies));
             throw new ServiceNotCreatedException('Service message must be an array of strings, ' . $problem . ' given');
         }
 
-        $arguments = array_map([$container, 'get'], $serviceDependencies);
+        $arguments = \array_map([$container, 'get'], $serviceDependencies);
 
         return new $requestedName(...$arguments);
     }

src/AbstractFactory/ReflectionBasedAbstractFactory.php

@@ -216,7 +216,7 @@ private function resolveParameter(ReflectionParameter $parameter, ContainerInter
         }
 
         $type = $parameter->getClass()->getName();
-        $type = isset($this->aliases[$type]) ? $this->aliases[$type] : $type;
+        $type = $this->aliases[$type] ?? $type;
 
         if (! $container->has($type)) {
             throw new ServiceNotFoundException(sprintf(

src/Config.php

@@ -63,7 +63,7 @@ class Config implements ConfigInterface
     public function __construct(array $config = [])
     {
         // Only merge keys we're interested in
-        foreach (array_keys($config) as $key) {
+        foreach (\array_keys($config) as $key) {
             if (! isset($this->allowedKeys[$key])) {
                 unset($config[$key]);
             }
@@ -98,12 +98,12 @@ private function merge(array $a, array $b)
         foreach ($b as $key => $value) {
             if ($value instanceof MergeReplaceKeyInterface) {
                 $a[$key] = $value->getData();
-            } elseif (isset($a[$key]) || array_key_exists($key, $a)) {
+            } elseif (isset($a[$key]) || \array_key_exists($key, $a)) {
                 if ($value instanceof MergeRemoveKey) {
                     unset($a[$key]);
-                } elseif (is_int($key)) {
+                } elseif (\is_int($key)) {
                     $a[] = $value;
-                } elseif (is_array($value) && is_array($a[$key])) {
+                } elseif (\is_array($value) && \is_array($a[$key])) {
                     $a[$key] = $this->merge($a[$key], $value);
                 } else {
                     $a[$key] = $value;

src/ServiceManager.php

@@ -183,7 +183,7 @@ public function get($name)
             return $this->services[$requestedName];
         }
 
-        $name = isset($this->resolvedAliases[$name]) ? $this->resolvedAliases[$name] : $name;
+        $name = $this->resolvedAliases[$name] ?? $name;
 
         // Next, if the alias should be shared, and we have cached the resolved
         // service, use it.
@@ -223,7 +223,7 @@ public function get($name)
     public function build($name, array $options = null)
     {
         // We never cache when using "build"
-        $name = isset($this->resolvedAliases[$name]) ? $this->resolvedAliases[$name] : $name;
+        $name = $this->resolvedAliases[$name] ?? $name;
         return $this->doCreate($name, $options);
     }
 
@@ -232,7 +232,7 @@ public function build($name, array $options = null)
      */
     public function has($name)
     {
-        $name  = isset($this->resolvedAliases[$name]) ? $this->resolvedAliases[$name] : $name;
+        $name  = $this->resolvedAliases[$name] ?? $name;
         $found = isset($this->services[$name]) || isset($this->factories[$name]);
 
         if ($found) {
@@ -656,7 +656,7 @@ private function resolveNewAliasesWithPreviouslyResolvedAliases(array $aliases)
      */
     private function getFactory($name)
     {
-        $factory = isset($this->factories[$name]) ? $this->factories[$name] : null;
+        $factory = $this->factories[$name] ?? null;
 
         $lazyLoaded = false;
         if (\is_string($factory) && \class_exists($factory)) {
@@ -710,7 +710,7 @@ private function createDelegatorFromName($name, array $options = null)
 
             if (! \is_callable($delegatorFactory)) {
                 if (\is_string($delegatorFactory)) {
-                    throw new ServiceNotCreatedException(sprintf(
+                    throw new ServiceNotCreatedException(\sprintf(
                         'An invalid delegator factory was registered; resolved to class or function "%s" '
                         . 'which does not exist; please provide a valid function name or class name resolving '
                         . 'to an implementation of %s',
@@ -719,9 +719,9 @@ private function createDelegatorFromName($name, array $options = null)
                     ));
                 }
 
-                throw new ServiceNotCreatedException(sprintf(
+                throw new ServiceNotCreatedException(\sprintf(
                     'A non-callable delegator, "%s", was provided; expected a callable or instance of "%s"',
-                    is_object($delegatorFactory) ? get_class($delegatorFactory) : gettype($delegatorFactory),
+                    \is_object($delegatorFactory) ? \get_class($delegatorFactory) : \gettype($delegatorFactory),
                     DelegatorFactoryInterface::class
                 ));
             }