Added more helpful errors for a bad configuration

Author: GeeH

src/AbstractFactory/ConfigAbstractFactory.php

@@ -55,12 +55,17 @@ public function __invoke(\Interop\Container\ContainerInterface $container, $requ
         if (!is_array($dependencies)
             || !array_key_exists($requestedName, $dependencies)
             || !is_array($dependencies[$requestedName])
-            || $dependencies[$requestedName] !== array_values(array_map('strval', $dependencies[$requestedName]))
         ) {
-            throw new ServiceNotCreatedException('Dependencies config must exist and be an array of strings');
+            throw new ServiceNotCreatedException('Dependencies config must exist and be an array');
         }
 
         $serviceDependencies = $dependencies[$requestedName];
+
+        if ($serviceDependencies !== array_values(array_map('strval', $serviceDependencies))) {
+            $problem = json_encode(array_map('gettype', $serviceDependencies));
+            throw new ServiceNotCreatedException('Service message must be an array of strings, ' . $problem . ' given');
+        }
+
         $arguments = array_map([$container, 'get'], $serviceDependencies);
 
         return new $requestedName(...$arguments);

test/AbstractFactory/ConfigAbstractFactoryTest.php

@@ -191,7 +191,7 @@ public function testExceptsWhenServiceConfigIsNotArray()
             ]
         );
         self::expectException(ServiceNotCreatedException::class);
-        self::expectExceptionMessage('Dependencies config must exist and be an array of strings');
+        self::expectExceptionMessage('Dependencies config must exist and be an array');
 
         $abstractFactory($serviceManager, 'Dirk_Gently');
     }
@@ -207,7 +207,7 @@ public function testExceptsWhenServiceConfigDoesNotExist()
             ]
         );
         self::expectException(ServiceNotCreatedException::class);
-        self::expectExceptionMessage('Dependencies config must exist and be an array of strings');
+        self::expectExceptionMessage('Dependencies config must exist and be an array');
 
         $abstractFactory($serviceManager, 'Dirk_Gently');
     }
@@ -225,7 +225,7 @@ public function testExceptsWhenServiceConfigForRequestedNameIsNotArray()
             ]
         );
         self::expectException(ServiceNotCreatedException::class);
-        self::expectExceptionMessage('Dependencies config must exist and be an array of strings');
+        self::expectExceptionMessage('Dependencies config must exist and be an array');
 
         $abstractFactory($serviceManager, 'Dirk_Gently');
     }
@@ -248,8 +248,10 @@ public function testExceptsWhenServiceConfigForRequestedNameIsNotArrayOfStrings(
             ]
         );
         self::expectException(ServiceNotCreatedException::class);
-        self::expectExceptionMessage('Dependencies config must exist and be an array of strings');
+        self::expectExceptionMessage(
+            'Service message must be an array of strings, ["string","string","string","integer"] given'
+        );
 
-        $abstractFactory($serviceManager, 'Dirk_Gently');
+        $abstractFactory($serviceManager, 'DirkGently');
     }
 }