Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

boesing
Copy link
Member

@boesing boesing commented Aug 19, 2019

Maybe same procedure as in #191

As the NotFoundHandler is technically a RequestHandler, I am moving it to the Handler namespace instead while marking the NotFoundHandler in the Middleware namespace as deprecated.

As the `NotFoundHandler` technically is a `RequestHandler` and not a `Middleware`, we should pass it to the proper namespace.
While marking the `NotFoundHandler` in the `Middleware` namespace as deprecated, we are piping all the logic to the right `NotFoundHandler` by just invoking its `RequestHandlerInterface::handle` method
@michalbundyra michalbundyra added this to the 3.3.0 milestone Oct 1, 2019
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-stratigility; a new issue has been opened at laminas/laminas-stratigility#1.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-stratigility. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-stratigility to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-stratigility.
  • In your clone of laminas/laminas-stratigility, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants