Skip to content

Commit 04b8967

Browse files
fix: various fixes (#715)
2 parents 3d042c9 + d2bbc76 commit 04b8967

File tree

7 files changed

+48
-16
lines changed

7 files changed

+48
-16
lines changed

src/app/onboarding/Setup/Items.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export function ConnectZenMLStep({ completed, hasDownstreamStep, active }: Onboa
1818
active={active}
1919
hasDownstream={hasDownstreamStep}
2020
completed={completed}
21-
title="Install and Connect ZenML (5 min)"
21+
title="Install and log in to ZenML (5 min)"
2222
>
2323
<div className="flex flex-col gap-5">
2424
<div>
@@ -28,7 +28,7 @@ export function ConnectZenMLStep({ completed, hasDownstreamStep, active }: Onboa
2828
/>
2929
</div>
3030
<div>
31-
<p className="mb-1 text-text-sm text-theme-text-secondary">Login to your ZenML Server</p>
31+
<p className="mb-1 text-text-sm text-theme-text-secondary">Log in to your ZenML Server</p>
3232
<Codesnippet code={getLoginCommand(data?.deployment_type || "other")} />
3333
</div>
3434
<HelpBox link="https://docs.zenml.io/user-guide/production-guide/deploying-zenml#connecting-to-a-deployed-zenml" />

src/app/settings/service-accounts/[service-account-id]/Success.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type Props = {
1111

1212
export function ApiKeySuccess({ value }: Props) {
1313
return (
14-
<div className="space-y-3 overflow-x-hidden px-7 py-5 text-text-md text-theme-text-primary ">
14+
<div className="space-y-3 overflow-x-hidden px-7 py-5 text-text-md text-theme-text-primary">
1515
<div className="space-y-0.5">
1616
<p className="text-text-md font-semibold text-theme-text-primary">
1717
Here is your new API Key
@@ -34,7 +34,7 @@ export function ApiKeySuccess({ value }: Props) {
3434
</a>
3535
</div>
3636
<p className="text-theme-text-secondary">
37-
To login to the ZenML server using the generated key, you can run the following CLI
37+
To log in to the ZenML server using the generated key, you can run the following CLI
3838
command and enter the API key when prompted:
3939
</p>
4040
<Codesnippet highlightCode wrap code={`zenml login --api-key ${window.location.origin}`} />

src/app/stacks/create/new-infrastructure/Providers/AWS.tsx

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,19 @@ export function AWSComponents({
8989
}}
9090
/>
9191
</div>
92+
<div className="py-3 pl-9 pr-5">
93+
<ComponentListItem
94+
title={components?.imageBuilder?.name || "AWS Image Builder"}
95+
subtitle={components?.imageBuilder?.id || "Build and manage container images"}
96+
badge={<ComponentBadge type="image_builder">Image Builder</ComponentBadge>}
97+
isLoading={isLoading}
98+
isSuccess={isSuccess}
99+
img={{
100+
src: "https://public-flavor-logos.s3.eu-central-1.amazonaws.com/image_builder/aws.png",
101+
alt: "AWS Image Builder logo"
102+
}}
103+
/>
104+
</div>
92105
</div>
93106
);
94107
}

src/components/SearchField.tsx

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import Search from "@/assets/icons/search.svg?react";
12
import { sanitizeSearchValue } from "@/lib/search";
23
import { objectToSearchParams } from "@/lib/url";
34
import { Input } from "@zenml-io/react-component-library";
@@ -36,7 +37,7 @@ export const SearchField = forwardRef<
3637
}, [debouncedSearch]);
3738

3839
function updateSearchQuery(value: string) {
39-
if (!!inMemoryHandler) {
40+
if (inMemoryHandler) {
4041
inMemoryHandler(value);
4142
return;
4243
}
@@ -64,14 +65,20 @@ export const SearchField = forwardRef<
6465
debouncedSearch(value);
6566
}
6667
return (
67-
<Input
68-
{...rest}
69-
ref={ref}
70-
value={searchQuery}
71-
onChange={searchHandler}
72-
placeholder="Search..."
73-
inputSize="md"
74-
/>
68+
<div className="relative">
69+
<Input
70+
className="pl-[36px]"
71+
{...rest}
72+
ref={ref}
73+
value={searchQuery}
74+
onChange={searchHandler}
75+
placeholder="Search..."
76+
inputSize="md"
77+
/>
78+
<div className="absolute inset-y-0 left-0 flex items-center pl-1">
79+
<Search className="size-4 fill-neutral-400" />
80+
</div>
81+
</div>
7582
);
7683
});
7784

src/components/dag-visualizer/layout/helper.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,18 @@ export function mergeRealAndPlacehodlerData({
6868
const duplicateRealArtifacts = finalNodes.filter((node) => node.id === realArtifact.id);
6969
if (duplicateRealArtifacts.length === 0) {
7070
finalNodes.push(realArtifact);
71+
} else {
72+
if (realArtifact.data.artifactType === "output") {
73+
for (const node of duplicateRealArtifacts) {
74+
// remove node from finalNodes based on id
75+
const index = finalNodes.findIndex((finalNode) => finalNode.id === node.id);
76+
if (index !== -1) {
77+
finalNodes.splice(index, 1);
78+
}
79+
}
80+
81+
finalNodes.push(realArtifact);
82+
}
7183
}
7284
});
7385

src/components/dag-visualizer/layout/real-data.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function extractNodes(stepConfig: StepDict, substitutions: Record<string, Record
3636
placeholderId,
3737
type: "artifact",
3838
substitutions: substitutions[stepName] || {},
39-
data: { ...version, name: outputName }
39+
data: { ...version, name: outputName, artifactType: "output" }
4040
});
4141
});
4242
});
@@ -49,7 +49,7 @@ function extractNodes(stepConfig: StepDict, substitutions: Record<string, Record
4949
id: artifactVersion.id,
5050
placeholderId,
5151
type: "artifact",
52-
data: { ...artifactVersion, name: inputName }
52+
data: { ...artifactVersion, name: inputName, artifactType: "input" }
5353
});
5454
});
5555
});

src/types/pipeline-runs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export type PipelineRunOvervieweParams = NonNullable<
1111
>;
1212
export type PipelineRunPage = components["schemas"]["Page_PipelineRunResponse_"];
1313

14-
type ArtifactNodeDetails = ArtifactVersion & { name: string };
14+
type ArtifactNodeDetails = ArtifactVersion & { name: string; artifactType: "input" | "output" };
1515
export type ArtifactNode = {
1616
id: string;
1717
placeholderId: string;

0 commit comments

Comments
 (0)