chore: setup dev container #25
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 17897114 | Triggered | Generic Password | ab81fe6 | .github/workflows/build-test.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
WalkthroughThis update introduces a development container configuration for Node.js and TypeScript, adds automated dependency management with Dependabot, and updates the PostgreSQL password from "abc123" to "postgres" across workflow and test configurations. The Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/testtools/src/schema.ts (1)
24-24: Avoid hardcoding PostgreSQL credentials.Instead of embedding
'postgres'directly in the connection URL, consider sourcing the password fromprocess.env.TEST_PG_PASSWORD(with a fallback) to centralize configuration and reduce duplication..devcontainer/devcontainer.json (2)
12-14: Use official PostgreSQL feature and expose the port
Switch to the official Microsoft devcontainer PostgreSQL feature, set the password, and forward port 5432 for host–container connectivity:- "ghcr.io/itsmechlark/features/postgresql:1": { - "version": "latest" - } + "ghcr.io/devcontainers/features/postgresql:1": { + "version": "latest", + "postgresPassword": "postgres" + } }, + "forwardPorts": [5432],
18-18: Ensure deterministic installs with frozen lockfile
Lockfile drift can cause inconsistent builds; add--frozen-lockfile:- "postCreateCommand": "pnpm install" + "postCreateCommand": "pnpm install --frozen-lockfile"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.devcontainer/devcontainer.json(1 hunks).github/dependabot.yml(1 hunks).github/workflows/build-test.yml(1 hunks).gitignore(1 hunks)packages/runtime/test/utils.ts(1 hunks)packages/testtools/src/schema.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-test (20.x)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (7)
packages/runtime/test/utils.ts (1)
35-35: Verify the updated default PostgreSQL password.The default test password has been changed to
'postgres'. Ensure that all references (CI workflows, schema generator, documentation) match this value to prevent connection failures..github/workflows/build-test.yml (1)
20-20: Confirm consistency of CI PostgreSQL password.The
POSTGRES_PASSWORDis set topostgresin the service definition. Verify that this aligns with the defaults used in local test utilities and schema generation to avoid mismatches..gitignore (1)
9-9: Ignore pnpm store directory.Good addition to prevent committing pnpm’s local store files.
.github/dependabot.yml (1)
1-21: Initial Dependabot configuration looks good.This will schedule weekly updates for both
devcontainersandnpmecosystems, targeting thedevbranch..devcontainer/devcontainer.json (3)
1-3: The header comments are informational and don’t require changes.
4-6: Devcontainer name and base image look good
Using the officialtypescript-node:1-22-bookwormimage ensures consistency across dev environments.
7-11: Git LFS feature configuration is correct
Automatically pulling the latest Git LFS and pinning the version aligns with best practices.
Summary by CodeRabbit