Skip to content

fix(vscode): filter out non-file doc uri in stage change hook #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2025
Merged

fix(vscode): filter out non-file doc uri in stage change hook #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92e86b8
fix(vscode): filter out non-file doc uri in stage change hook
ymc9 Oct 17, 2025
d54e667
update
ymc9 Oct 17, 2025
8030afc
update
ymc9 Oct 17, 2025
347dc8f
update
ymc9 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ide/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "zenstack-v3",
"publisher": "zenstack",
"version": "3.0.9",
"version": "3.0.11",
"displayName": "ZenStack V3 Language Tools",
"description": "VSCode extension for ZenStack (v3) ZModel language",
"private": true,
Expand Down
6 changes: 6 additions & 0 deletions packages/language/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,19 @@ export function createZModelLanguageServices(

// when documents reach Parsed state, inspect plugin declarations and load corresponding
// plugin zmodel docs
// Note we must use `onBuildPhase` instead of `onDocumentPhase` here because the latter is
// not called when not running inside a language server.
shared.workspace.DocumentBuilder.onBuildPhase(DocumentState.Parsed, async (documents) => {
for (const doc of documents) {
if (doc.parseResult.lexerErrors.length > 0 || doc.parseResult.parserErrors.length > 0) {
// balk if there are lexer or parser errors
continue;
}

if (doc.uri.scheme !== 'file') {
continue;
}

const schemaPath = fileURLToPath(doc.uri.toString());
const pluginSchemas = getPluginDocuments(doc.parseResult.value as Model, schemaPath);
for (const plugin of pluginSchemas) {
Expand Down