merge dev to main #61
Conversation
* chore: add pr script, update publish script * update pr base
There was a problem hiding this comment.
Pull Request Overview
This PR merges recent changes from dev into main and updates several npm scripts to support new workflows.
- Adds a new "pr" npm script to create pull requests with a preset base branch.
- Updates the "publish-all" script to include the "--access public" flag for package publishing.
Comments suppressed due to low confidence (1)
package.json:12
- The new 'pr' script uses '--base dev', but the PR metadata indicates a merge from dev to main. Please verify if the base should be 'main' to reflect the intended merge target.
"pr": "gh pr create --fill-first --base dev",
WalkthroughThis change updates the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CLI
participant GitHub
Developer->>CLI: Run "pnpm pr"
CLI->>GitHub: Create PR (base: dev, autofill details)
GitHub-->>Developer: PR created
Developer->>CLI: Run "pnpm publish-all"
CLI->>NPM Registry: Publish all packages with public access and 'next' tag
NPM Registry-->>Developer: Packages published
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
package.json (2)
12-12: Hard-coded base branch in the newprscript reduces flexibility
gh pr create --fill-first --base devassumes every PR should targetdev.
Hot-fixes or release branches that must go straight tomain(or any other branch) will require manually overriding the script or bypassing it.- "pr": "gh pr create --fill-first --base dev", + // BASE defaults to dev but can be overridden, works on all shells via cross-env + "pr": "cross-env BASE=${BASE:-dev} gh pr create --fill-first --base $BASE",(Requires adding
cross-envto dev-deps.)At minimum, document the requirement that contributors need GitHub CLI installed and authenticated, otherwise the script will silently fail.
14-14:--access publiccan break publish if any workspace package is meant to stay privateAdding
--access publicforces every scoped package (e.g.@org/pkg) to be published publicly.
• NPM rejects private scopes with this flag.
• The CI job will fail half-way, leaving some packages unpublished and versions bumped.Confirm that all packages under
./packages/**are intended for public NPM.
If not, consider reading each package’s ownpublishConfig.accessor publishing per-package:- "publish-all": "pnpm --filter \"./packages/**\" -r publish --access public --tag next", + "publish-all": "pnpm --filter \"./packages/**\" -r exec -- pnpm publish --tag next",(or split into
publish-public/publish-private).Also think about adding
--no-git-checks --yesto prevent interactive prompts in CI.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-test (20.x)
- GitHub Check: Analyze (javascript-typescript)
chore: add pr script, update publish script
update pr base
Summary by CodeRabbit