fix: nested select result typing, simplifying ORM query result types #92

ymc9 · 2025-07-13T07:04:07Z

Summary by CodeRabbit

Refactor
- Improved the handling of returned data structures for model operations, resulting in more streamlined and simplified results for end-users.
- Enhanced support for nested selections and relations, allowing for more precise queries and outputs when working with related data.
Style
- Minor adjustments to internal type utilities for better consistency and type accuracy.
Tests
- Expanded test coverage for nested selection, inclusion, and omission in queries to ensure correctness and type safety.

coderabbitai · 2025-07-13T07:04:13Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 85d8c5d and d9a8c3b.

📒 Files selected for processing (4)

packages/runtime/src/client/contract.ts (15 hunks)
packages/runtime/src/client/crud-types.ts (1 hunks)
packages/runtime/src/utils/type-utils.ts (2 hunks)
packages/runtime/test/typing/verify-typing.ts (2 hunks)

 _____________________________________________
< You shall not pass...without a code review! >
 ---------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting in your project's settings in CodeRabbit to enable early access features such as new models, tools, and more.

✨ Finishing Touches

📝 Docstrings were successfully generated. (🔄 Check again to generate docstrings again)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR fixes nested select result typing in the ORM by simplifying query result types. The main change involves updating the type system to properly handle nested select queries with mixed include/omit operations and applying a Simplify type utility to flatten complex type intersections.

Enhances the ModelSelectResult type to properly differentiate between select and include/omit operations in nested queries
Applies the Simplify type utility to all ORM operation return types to improve TypeScript IntelliSense and readability
Adds comprehensive test cases for nested select scenarios with complex field selection patterns

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
packages/runtime/test/typing/verify-typing.ts	Adds test cases for nested select operations with author relations and mixed include/omit scenarios
packages/runtime/src/utils/type-utils.ts	Moves and improves the `Simplify` type utility with recursive object flattening
packages/runtime/src/client/crud-types.ts	Enhances `ModelSelectResult` to properly handle nested select vs include/omit operations
packages/runtime/src/client/contract.ts	Wraps all ORM operation return types with `Simplify` for better type display

packages/runtime/src/utils/type-utils.ts

Co-authored-by: Copilot <[email protected]>

ymc9 · 2025-07-13T07:22:51Z

@coderabbitai review

coderabbitai · 2025-07-13T07:22:56Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ymc9

Docstrings generation was requested by @ymc9. * #92 (comment) The following files were modified: * `packages/runtime/src/utils/type-utils.ts` * `packages/runtime/test/typing/verify-typing.ts`

coderabbitai · 2025-07-13T07:25:24Z

Note

Generated docstrings for this pull request at #93

fix: nested select result typing, simplifying ORM query result types

08df50c

Copilot AI review requested due to automatic review settings July 13, 2025 07:04

Copilot AI reviewed Jul 13, 2025

View reviewed changes

packages/runtime/src/utils/type-utils.ts Outdated Show resolved Hide resolved

ymc9 and others added 2 commits July 13, 2025 15:07

Update packages/runtime/src/utils/type-utils.ts

1ee1209

Co-authored-by: Copilot <[email protected]>

update

d9a8c3b

ymc9 merged commit a84a1ca into dev Jul 13, 2025
3 checks passed

coderabbitai bot mentioned this pull request Jul 13, 2025

📝 Add docstrings to fix/nested-select-typing #93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: nested select result typing, simplifying ORM query result types #92

fix: nested select result typing, simplifying ORM query result types #92

Uh oh!

ymc9 commented Jul 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 13, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

ymc9 commented Jul 13, 2025

Uh oh!

coderabbitai bot commented Jul 13, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jul 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix: nested select result typing, simplifying ORM query result types #92

fix: nested select result typing, simplifying ORM query result types #92

Uh oh!

Conversation

ymc9 commented Jul 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

ymc9 commented Jul 13, 2025

Uh oh!

coderabbitai bot commented Jul 13, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jul 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ymc9 commented Jul 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 13, 2025 •

edited

Loading