Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ import {
isEnum,
isReferenceExpr,
} from '@zenstackhq/language/ast';
import { isDataModelFieldReference, isFutureExpr, isRelationshipField, resolved } from '@zenstackhq/sdk';
import {
isDataModelFieldReference,
isDelegateModel,
isFutureExpr,
isRelationshipField,
resolved,
} from '@zenstackhq/sdk';
import { ValidationAcceptor, streamAst } from 'langium';
import pluralize from 'pluralize';
import { AstValidator } from '../types';
Expand Down Expand Up @@ -164,6 +170,31 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@@unique')
private _checkUnique(attr: AttributeApplication, accept: ValidationAcceptor) {
const fields = attr.args[0]?.value;
if (fields && isArrayExpr(fields)) {
fields.items.forEach((item) => {
if (!isReferenceExpr(item)) {
accept('error', `Expecting a field reference`, { node: item });
return;
}
if (!isDataModelField(item.target.ref)) {
accept('error', `Expecting a field reference`, { node: item });
return;
}

if (item.target.ref.$container !== attr.$container && isDelegateModel(item.target.ref.$container)) {
accept('error', `Cannot use fields inherited from a polymorphic base model in \`@@unique\``, {
node: item,
});
}
});
} else {
accept('error', `Expected an array of field references`, { node: fields });
}
}

private validatePolicyKinds(
kind: string,
candidates: string[],
Expand Down
29 changes: 29 additions & 0 deletions tests/regression/tests/issue-1758.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { loadModelWithError } from '@zenstackhq/testtools';

describe('issue 1758', () => {
it('regression', async () => {
await expect(
loadModelWithError(
`
model Organization {
id String @id @default(cuid())
contents Content[] @relation("OrganizationContents")
}

model Content {
id String @id @default(cuid())
contentType String
organization Organization @relation("OrganizationContents", fields: [organizationId], references: [id])
organizationId String
@@delegate(contentType)
}

model Store extends Content {
name String
@@unique([organizationId, name])
}
`
)
).resolves.toContain('Cannot use fields inherited from a polymorphic base model in `@@unique`');
});
});
Loading