-
-
Notifications
You must be signed in to change notification settings - Fork 22
chore: support Symfony 8 #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.x
Are you sure you want to change the base?
Conversation
0a5e726 to
08cff55
Compare
composer.json
Outdated
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/nikophil/Mink" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jobs: | ||
| test: | ||
| uses: zenstruck/.github/.github/workflows/php-test-symfony.yml@main | ||
| uses: nikophil/.github-1/.github/workflows/php-test-symfony.yml@chore/sf-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5e3ef4d to
0b0b256
Compare
|
symfony/panther does now allow symfony 8 with 2.3.0 |
|
Yes, symfony/panther#678 is open |
|
@Chris53897 yes I'm going to finish this soon @Kocal I don't understand the PR you linked: Panther seems to already support SF 8? |
|
More or less, some minor things are missing for truly Symfony 8 compatibility |
|
I just realized that we're definitely stuck waiting for symfony/panther#678 to be merged |
fixes #183
this would need zenstruck/.github#5 in order to be tested on SF 8