Add prefix-without-leading-slash to s3 URLs#126
Open
josuealcalde-utamed wants to merge 1 commit intozenstruck:1.xfrom
Open
Add prefix-without-leading-slash to s3 URLs#126josuealcalde-utamed wants to merge 1 commit intozenstruck:1.xfrom
josuealcalde-utamed wants to merge 1 commit intozenstruck:1.xfrom
Conversation
josuealcalde-utamed
force-pushed
the
path-without-leading-slash
branch
from
396096c to
4863802
Compare
In previous versions, when a prefix is set in flysystem+s3 urls, it preservers a leading slash as first character. In S3 this is not desirable, since it will add a directory with "/" an URLs will result in double slash https://bucket.s3-domain//prefix/... Since this cannot be fixed without getting a BC, we add a parameter to get a correct behavior.
josuealcalde-utamed
force-pushed
the
path-without-leading-slash
branch
from
4863802 to
c6a84bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions, when a prefix is set in flysystem+s3 urls, it preservers a leading slash as first character. In S3 this is not desirable, since it will add a directory with "/" an URLs will result in double slash https://bucket.s3-domain//prefix/...
Since this cannot be fixed without getting a BC, we add a parameter to get a correct behavior.