Fix using refresh_all() with flush_after()
#999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
reviewed
Oct 9, 2025
| $this->flush($om); | ||
| } | ||
| } | ||
| PersistedObjectsTracker::updateIds(); |
There was a problem hiding this comment.
Juste for you to know, in a further PR, we plan to remove this method, in favor of future so-called "foundry hooks"
see #986
I think it will work out of the box then. But we're not ready to merge it, so let's release your fix now 👍
There was a problem hiding this comment.
Great, thanks for the info.
|
@nikophil Thank you for the reviews/merges, they are appreciated as well 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
refresh_all()doesn't work withflush_after()because the ids never get updated.