zephyrCommon: Add comment at the end of the anonymous namespace#131
Closed
soburi wants to merge 2 commits intozephyrproject-rtos:nextfrom
Closed
zephyrCommon: Add comment at the end of the anonymous namespace#131soburi wants to merge 2 commits intozephyrproject-rtos:nextfrom
soburi wants to merge 2 commits intozephyrproject-rtos:nextfrom
Conversation
Added a comment because it was difficult to understand where the namespace ends. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
comment_end_of_namespace
branch
from
064726c to
1300bf4
Compare
Ayush1325
approved these changes
Sep 8, 2025
DhruvaG2000
approved these changes
Sep 24, 2025
Member
DhruvaG2000
left a comment
DhruvaG2000
left a comment
There was a problem hiding this comment.
You're right, this is actually also stemming from the fact that this file has just got wayy too big than it should be and deserves a refactor. I will add this in my TODO.
Member
|
@soburi no merge commits please, please rebase and push :) |
Member
|
manually applied, thanks. |
soburi
pushed a commit
to soburi/ArduinoCore-zephyr
that referenced
this pull request
Sep 24, 2025
…drinfo Added missing call to freeaddrinfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a comment because it was difficult to understand where the namespace ends.