samples: hello_arduino: Correct printk format specifier#145
Merged
DhruvaG2000 merged 1 commit intozephyrproject-rtos:nextfrom Feb 3, 2026
Merged
samples: hello_arduino: Correct printk format specifier#145DhruvaG2000 merged 1 commit intozephyrproject-rtos:nextfrom
DhruvaG2000 merged 1 commit intozephyrproject-rtos:nextfrom
Conversation
soburi
changed the title
soburi
requested review from
DhruvaG2000,
beriberikix and
szczys
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request combines two distinct types of changes: a format specifier correction in the hello_arduino sample and infrastructure updates to support board revision-specific overlay files across all samples. The PR title and description only mention the format specifier fix, but the actual changes are much more extensive.
Changes:
- Fixed printk format specifiers from %d to %zd for size_t variables in hello_arduino sample
- Added conditional logic to all sample CMakeLists.txt files to support board-revision-specific overlay files
- Modified main CMakeLists.txt to change variant directory detection logic from BOARD with NORMALIZED_BOARD_QUALIFIERS to BOARD and NORMALIZED_BOARD_TARGET with double-underscore replacement
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/hello_arduino/src/app.cpp | Corrected printk format specifiers from %d to %zd for size_t variables |
| samples/hello_arduino/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/analog_input/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/attach_interrupt/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/blinky_arduino/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/button_press_led/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/fade/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/i2cdemo/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/serial_event/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/spi_controller/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| samples/threads_arduino/CMakeLists.txt | Added conditional logic to select board-revision-specific overlay files |
| CMakeLists.txt | Modified variant directory detection logic and added double-underscore replacement for NORMALIZED_BOARD_TARGET |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
soburi
force-pushed
the
correct_printk_format
branch
from
5f3f8fc to
cbd179a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixed to use %zd which corresponds to size_t. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
correct_printk_format
branch
from
cbd179a to
24b2346
Compare
DhruvaG2000
approved these changes
Feb 3, 2026
soburi
pushed a commit
to soburi/ArduinoCore-zephyr
that referenced
this pull request
Feb 6, 2026
soburi
pushed a commit
to soburi/ArduinoCore-zephyr
that referenced
this pull request
Feb 6, 2026
soburi
pushed a commit
to soburi/ArduinoCore-zephyr
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed to use %zd which corresponds to size_t.