zephyrCommon: Make configurable the max number of tones by soburi · Pull Request #152 · zephyrproject-rtos/ArduinoCore-zephyr

soburi · 2026-02-01T15:32:53Z

Fixed a bug where tone() with duration=0 would stop the tone immediately instead of ringing infinitely.
Allows you to change the maximum number of notes that can be played with tone().
Add a tone_doremi sample to demonstrate how to sounding with tone API

Copilot

Pull request overview

This PR updates the Zephyr Arduino core’s tone() implementation to support more flexible timer allocation by dynamically selecting unused timers, and adds a Kconfig option to control the maximum number of concurrent tones.

Changes:

Add CONFIG_ARDUINO_MAX_TONES (default -1) to configure the tone timer pool size.
Track timer usage via a per-timer pin field and allocate/release timers dynamically in tone()/noTone().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
cores/arduino/zephyrCommon.cpp	Implements dynamic allocation/release of tone timers and makes the pool size configurable.
Kconfig	Adds `ARDUINO_MAX_TONES` configuration option (default `-1` for auto sizing).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Kconfig

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

samples/tone_doremi/README.rst

samples/tone_doremi/src/app.cpp

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

cores/arduino/zephyrCommon.cpp:281

When frequency is 0, the function returns early without clearing the timer state (setting pt->pin = pin_size_t(-1)). This means the timer slot remains allocated to this pin even though it's no longer active. If this pin calls tone() again later, it will find and reuse the same timer, which is fine. However, if the maximum number of timers is reached and this pin's timer is not properly freed, it could prevent other pins from allocating timers. Consider adding pt->pin = pin_size_t(-1); before the return on line 281 to properly free the timer slot.

  if (frequency == 0) {
    gpio_pin_set_dt(spec, 0);
    return;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

samples/tone_doremi/README.rst

Kconfig

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Kconfig

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

DhruvaG2000 · 2026-02-09T11:20:57Z

cores/arduino/zephyrCommon.cpp

+
+
+    if (pin == pin_size_t(-1)) {
+      unusedIndex = i;


This slot could be claimed by another thread right?

DhruvaG2000 · 2026-02-09T11:21:07Z

cores/arduino/zephyrCommon.cpp

+
+    k_spin_unlock(&arduino_pin_timers[i].lock, key);
+
+


remove extra newline please

I've overhauled this entire function.

DhruvaG2000 · 2026-02-09T11:22:11Z

cores/arduino/zephyrCommon.cpp

+    k_spin_unlock(&arduino_pin_timers[i].lock, key);
+
+
+    if (pin == pin_size_t(-1)) {


The function releases the lock immediately after reading pin, then uses that stale value. Between unlock and the check, another thread could claim that slot right?

DhruvaG2000 · 2026-02-09T11:23:37Z

cores/arduino/zephyrCommon.cpp

+  size_t unusedIndex = size_t(-1);
+
+  for (size_t i = 0; i < ARRAY_SIZE(arduino_pin_timers); i++) {
+    k_spinlock_key_t key = k_spin_lock(&arduino_pin_timers[i].lock);
+    size_t pin = arduino_pin_timers[i].pin;
+
+    k_spin_unlock(&arduino_pin_timers[i].lock, key);
+
+
+    if (pin == pin_size_t(-1)) {
+      unusedIndex = i;
+    }
+
+    if (pin == pinNumber) {
+      return &arduino_pin_timers[i];
+    }
+  }
+
+  if (unusedIndex != size_t(-1) && !active_only) {
+    return &arduino_pin_timers[unusedIndex];


oh I see copilot had already caught this? What was the reason for resolving?

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

samples/tone_doremi/CMakeLists.txt

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

DhruvaG2000

just one final comment

DhruvaG2000 · 2026-02-10T06:38:21Z

cores/arduino/zephyrCommon.cpp

    pt->pin = pin_size_t(-1);
  } else {
-    if (pin >= 0) {
+    if (pin != pin_size_t(-1)) {


why are these changes inside add tone_doremi sample? Can be very misleading, please split into another commit.

Oops!
It was misoperation, Fixed. Thank you for catching.

Fixed a bug where tone() with duration=0 would stop the tone immediately instead of ringing infinitely. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Allows you to change the maximum number of notes that can be played with `tone()`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Add a tone_doremi sample to demonstrate how to sounding with tone API Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

soburi force-pushed the use_available_timer branch 4 times, most recently from d1fa1d4 to 41a8a6b Compare February 3, 2026 23:16

soburi marked this pull request as ready for review February 4, 2026 01:17

soburi requested review from DhruvaG2000, beriberikix and szczys as code owners February 4, 2026 01:17

Copilot AI review requested due to automatic review settings February 4, 2026 01:17

soburi marked this pull request as draft February 4, 2026 01:18

Copilot started reviewing on behalf of soburi February 4, 2026 01:18 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

Kconfig Show resolved Hide resolved

soburi force-pushed the use_available_timer branch 5 times, most recently from f424836 to 2c4afe2 Compare February 5, 2026 11:53

soburi requested a review from Copilot February 5, 2026 11:54

Copilot started reviewing on behalf of soburi February 5, 2026 11:54 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

soburi force-pushed the use_available_timer branch from 13e2210 to 2c0babd Compare February 5, 2026 13:29

soburi requested a review from Copilot February 5, 2026 13:29

Copilot started reviewing on behalf of soburi February 5, 2026 13:30 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

soburi force-pushed the use_available_timer branch from 3d7c27c to 06b1038 Compare February 5, 2026 13:38

soburi requested a review from Copilot February 5, 2026 13:56

Copilot started reviewing on behalf of soburi February 5, 2026 13:56 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

samples/tone_doremi/README.rst Outdated Show resolved Hide resolved

Kconfig Show resolved Hide resolved

soburi changed the title ~~zephyrCommon: Use available tone timers~~ zephyrCommon: Make configurable the max number of tones Feb 5, 2026

soburi force-pushed the use_available_timer branch from ca91026 to 00dc900 Compare February 5, 2026 14:11

soburi requested a review from Copilot February 8, 2026 05:53

Copilot started reviewing on behalf of soburi February 8, 2026 05:53 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

Kconfig Show resolved Hide resolved

soburi force-pushed the use_available_timer branch from b5304d5 to 312374f Compare February 8, 2026 06:26

soburi requested a review from Copilot February 8, 2026 06:26

Copilot started reviewing on behalf of soburi February 8, 2026 06:27 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

soburi force-pushed the use_available_timer branch from 1ae6215 to f9a2e52 Compare February 8, 2026 07:34

soburi requested a review from Copilot February 8, 2026 07:34

Copilot started reviewing on behalf of soburi February 8, 2026 07:34 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

soburi force-pushed the use_available_timer branch 6 times, most recently from b837aad to 6fffccc Compare February 9, 2026 09:52

DhruvaG2000 reviewed Feb 9, 2026

View reviewed changes

soburi marked this pull request as draft February 9, 2026 13:23

Copilot AI reviewed Feb 9, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

samples/tone_doremi/CMakeLists.txt Show resolved Hide resolved

Copilot AI reviewed Feb 9, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

Copilot AI reviewed Feb 9, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

Copilot AI reviewed Feb 9, 2026

View reviewed changes

DhruvaG2000 reviewed Feb 10, 2026

View reviewed changes

soburi added 3 commits February 10, 2026 13:35

cores: arduino: zephyrCommon: Correct tone() behavior with duration=0

9aecd42

Fixed a bug where tone() with duration=0 would stop the tone immediately instead of ringing infinitely. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

zephyrCommon: Make configurable the max number of tones

a217367

Allows you to change the maximum number of notes that can be played with `tone()`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

samples: Added tone_doremi sample

033ed29

Add a tone_doremi sample to demonstrate how to sounding with tone API Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

DhruvaG2000 approved these changes Feb 10, 2026

View reviewed changes

soburi mentioned this pull request Feb 14, 2026

Tasks for reunite arduino repo #162

Open

16 tasks

		k_spin_unlock(&arduino_pin_timers[i].lock, key);


		if (pin == pin_size_t(-1)) {

Conversation

soburi commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

DhruvaG2000 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

DhruvaG2000 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

soburi Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

DhruvaG2000 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

DhruvaG2000 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

soburi commented Feb 1, 2026 •

edited

Loading