Support conditional dependencies using "depends on A if B". #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grahamroff-dev I'm not sure what the review expectations are for this repo, but you might want to rebase and clean up history -- I see 3 commits, one of which is a merge commit, when I'd naively only have expected 1 |
|
@grahamroff-dev no need to close the PR when revising. Instead, force-push into the existing PR branch. |
|
Sorry, wanted to redo from a feature branch on my side anyway. New clean PR #21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the "depends on" syntax to support conditional dependencies using "... if ". While functionally equivalent to "depends on !B || A", "depends on A if B" is much more readable.
This change is implemented by converting the "A if B" syntax into the "!B || A" syntax during "depends on" token processing.