Skip to content

Conversation

soburi
Copy link
Member

@soburi soburi commented Aug 23, 2025

Added a comment because it was difficult to understand where the namespace ends.

Added a comment because it was difficult to understand
where the namespace ends.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi force-pushed the comment_end_of_namespace branch from 064726c to 1300bf4 Compare September 7, 2025 21:47
@soburi soburi requested a review from DhruvaG2000 September 10, 2025 07:22
Copy link
Member

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this is actually also stemming from the fact that this file has just got wayy too big than it should be and deserves a refactor. I will add this in my TODO.

@DhruvaG2000
Copy link
Member

@soburi no merge commits please, please rebase and push :)

@DhruvaG2000
Copy link
Member

manually applied, thanks.

soburi pushed a commit to soburi/gsoc-2022-arduino-core that referenced this pull request Sep 24, 2025
…drinfo

Added missing call to freeaddrinfo
@soburi soburi deleted the comment_end_of_namespace branch September 24, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants