This repository was archived by the owner on Apr 6, 2022. It is now read-only.
check_compliance.py: UNDEF_KCONFIG_WHITELIST: add CONFIG_SHIFT #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CONFIG_SHIFT to Kconfig exclusion. This definition is from LL from STM32MP1X Cube, in ext/hal/st/stm32cube/stm32mp1xx/drivers/include/stm32mp1xx_ll_rcc.h. This solve false positive in zephyrproject-rtos/zephyr#15426 Signed-off-by: Yaël BOUTREUX <[email protected]>
ulfalizer
approved these changes
Apr 12, 2019
ulfalizer
reviewed
Apr 12, 2019
| "CONFIG_REG1", | ||
| "CONFIG_REG2", | ||
| "CONFIG_SEL", | ||
| "CONFIG_SHIFT", #From STM32MP1 Cube (ext/hal/), file stm32mp1xx_ll_rcc.h |
There was a problem hiding this comment.
Nit: Please put a space after # (and /*, and //) in the future. It's a much more common style.
There was a problem hiding this comment.
Will remember this for next time, thank you !
|
CC @nashif |
You are right, the variable will be renamed to CFG_SHIFT, thank you ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CONFIG_SHIFT to Kconfig exclusion.
This definition is from LL from STM32MP1X Cube,
in ext/hal/st/stm32cube/stm32mp1xx/drivers/include/stm32mp1xx_ll_rcc.h.
This solve false positive in zephyrproject-rtos/zephyr#15426
Signed-off-by: Yaël BOUTREUX [email protected]