Skip to content

Commit fc6da81

Browse files
Correct build issues related to issue ARM-software#197
Problem with f16 Implicit conversions from float to int
1 parent 60a6ec1 commit fc6da81

File tree

5 files changed

+25
-10
lines changed

5 files changed

+25
-10
lines changed

Source/DistanceFunctions/arm_dtw_path_f32.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,18 +141,19 @@ ARM_DSP_ATTRIBUTE void arm_dtw_path_f32(const arm_matrix_instance_f32 *pDTW,
141141

142142
/* Reverse the path */
143143
int16_t *fh,*sh;
144+
int16_t itemp;
144145
fh = pPath;
145146
sh = pPath + 2* (*pathLength)-2;
146147
int halfLength = (*pathLength)>>1;
147148
for(int i = 0; i< halfLength; i++)
148149
{
149-
temp = fh[0];
150+
itemp = fh[0];
150151
fh[0] = sh[0];
151-
sh[0] = temp;
152+
sh[0] = itemp;
152153

153-
temp = fh[1];
154+
itemp = fh[1];
154155
fh[1] = sh[1];
155-
sh[1] = temp;
156+
sh[1] = itemp;
156157

157158
fh += 2;
158159
sh -= 2;

Source/FastMathFunctions/arm_atan2_f16.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ ARM_DSP_ATTRIBUTE arm_status arm_atan2_f16(float16_t y,float16_t x,float16_t *re
135135
}
136136
else
137137
{
138-
if (signbit(y))
138+
if (signbit((float)y))
139139
{
140140
*result= -(_Float16)PIF16;
141141
}

Source/TransformFunctions/arm_bitreversal_f16.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,7 @@
2828

2929
#include "dsp/transform_functions_f16.h"
3030

31-
void arm_bitreversal_f16(
32-
float16_t * pSrc,
33-
uint16_t fftSize,
34-
uint16_t bitRevFactor,
35-
const uint16_t * pBitRevTab);
31+
3632

3733
/*
3834
* @brief In-place bit reversal function.
@@ -44,6 +40,12 @@ const uint16_t * pBitRevTab);
4440

4541
#if defined(ARM_FLOAT16_SUPPORTED)
4642

43+
void arm_bitreversal_f16(
44+
float16_t * pSrc,
45+
uint16_t fftSize,
46+
uint16_t bitRevFactor,
47+
const uint16_t * pBitRevTab);
48+
4749
ARM_DSP_ATTRIBUTE void arm_bitreversal_f16(
4850
float16_t * pSrc,
4951
uint16_t fftSize,

Testing/cmsis_build/cdefault.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ default:
77
C:
88
- -Wsign-compare
99
- -Wdouble-promotion
10+
- -Wfloat-conversion
1011
- -DNDEBUG
1112
- -Wall
1213
- -Wextra
@@ -55,6 +56,7 @@ default:
5556
C:
5657
- -Wsign-compare
5758
- -Wdouble-promotion
59+
- -Wfloat-conversion
5860
- -DNDEBUG
5961
- -Wall
6062
- -Wextra
@@ -102,6 +104,7 @@ default:
102104
C:
103105
- -Wsign-compare
104106
- -Wdouble-promotion
107+
- -Wfloat-conversion
105108
- -DNDEBUG
106109
- -Wall
107110
- -Wextra

dsppp/cdefault.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ default:
77
C:
88
- -Wsign-compare
99
- -Wdouble-promotion
10+
- -Wfloat-conversion
1011
- -DNDEBUG
1112
- -Wall
1213
- -Wextra
@@ -30,6 +31,8 @@ default:
3031
CPP:
3132
- -fno-rtti
3233
- -fno-exceptions
34+
- -Wdouble-promotion
35+
- -Wfloat-conversion
3336
- -DNDEBUG
3437
- -Wall
3538
- -Wextra
@@ -53,6 +56,7 @@ default:
5356
C:
5457
- -Wsign-compare
5558
- -Wdouble-promotion
59+
- -Wfloat-conversion
5660
- -DNDEBUG
5761
- -Wall
5862
- -Wextra
@@ -73,6 +77,8 @@ default:
7377
CPP:
7478
- -fno-rtti
7579
- -fno-exceptions
80+
- -Wdouble-promotion
81+
- -Wfloat-conversion
7682
- -DNDEBUG
7783
- -Wall
7884
- -Wextra
@@ -100,6 +106,7 @@ default:
100106
C:
101107
- -Wsign-compare
102108
- -Wdouble-promotion
109+
- -Wfloat-conversion
103110
- -DNDEBUG
104111
- -Wall
105112
- -Wextra
@@ -122,6 +129,8 @@ default:
122129
CPP:
123130
- -fno-rtti
124131
- -fno-exceptions
132+
- -Wdouble-promotion
133+
- -Wfloat-conversion
125134
- -DNDEBUG
126135
- -Wall
127136
- -Wextra

0 commit comments

Comments
 (0)