Skip to content

Conversation

RobinKastberg
Copy link
Contributor

@RobinKastberg RobinKastberg commented Jan 24, 2025

Currently CMSIS 5 is broken with the IAR compiler, and will not be patched. I tried lifting zephyr to CMSIS 6 but this was non-trivial. (my try is here:
zephyrproject-rtos/zephyr#84330 and zephyrproject-rtos/CMSIS_6#1
)

One way to fix this without ugly kludges inside zephyr is backporting this fix to CMSIS 5.9.0.
ARM-software/CMSIS_6#102

Zephyr PR is here:
zephyrproject-rtos/zephyr#84481
Since currently there are no IAR tests or handling in zephyr I don't expect this change to break anything currently

@RobinKastberg
Copy link
Contributor Author

@carlescufi @stephanosio this is one of the last PRs we need before we can get experimental IAR support

Copy link

@wearyzen wearyzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add below to the commit message?
"Cherry picked from 1ba98967e8bc860c500c4477a4586f84aa26eae4"

I tried lifting zephyr to CMSIS 6 but this was non-trivial.

Since you have spend some time on this already, would you be able to list down the things that are needed to enable this apart from what is mentioned here?

@RobinKastberg
Copy link
Contributor Author

RobinKastberg commented Jan 25, 2025

Could you please add below to the commit message? "Cherry picked from 1ba98967e8bc860c500c4477a4586f84aa26eae4"

Sure, but since this is in another repo wouldn't this be confusing?
Maybe a link to zephyrproject-rtos/CMSIS_6@db3f170 ?

I tried lifting zephyr to CMSIS 6 but this was non-trivial.

Since you have spend some time on this already, would you be able to list down the things that are needed to enable this apart from what is mentioned here?

The only issue I could find was that Cortex-R support doesn't exist in CMSIS_6 but is zephyr-specific,
coming from here: 54eaf19.

All other tests for Cortex-M, including CMSIS-DSP and CMSIS-NN went just fine. I didn't test TF-M properly but that is already lifted to CMSIS_6 so should be solvable.

Should I create an issue relating to this?

@wearyzen
Copy link

Could you please add below to the commit message? "Cherry picked from 1ba98967e8bc860c500c4477a4586f84aa26eae4"

Sure, but since this is in another repo wouldn't this be confusing? Maybe a link to zephyrproject-rtos/CMSIS_6@db3f170 ?

Yeah a link to zephyrproject-rtos/CMSIS_6@db3f170 looks fine too.

I tried lifting zephyr to CMSIS 6 but this was non-trivial.

Since you have spend some time on this already, would you be able to list down the things that are needed to enable this apart from what is mentioned here?

The only issue I could find was that Cortex-R support doesn't exist in CMSIS_6 but is zephyr-specific, coming from here: 54eaf19.

All other tests for Cortex-M, including CMSIS-DSP and CMSIS-NN went just fine. I didn't test TF-M properly but that is already lifted to CMSIS_6 so should be solvable.

Should I create an issue relating to this?

Thanks for summarizing this, yeah if there isn't an existing issue you can create one.

Currently CMSIS 5 is broken with the IAR compiler, and will not be patched.
I tried lifting zephyr to CMSIS 6 but this was non-trivial.

One way to fix this without ugly kludges inside zephyr
is backporting the fix from
zephyrproject-rtos/CMSIS_6/commit/db3f1703087023f67465bbd338509e2d5322746c
fix to CMSIS 5.9.0.

Signed-off-by: Robin Kastberg <[email protected]>
@RobinKastberg
Copy link
Contributor Author

updated commit message

@kartben kartben merged commit d1b8b20 into zephyrproject-rtos:master Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants