Skip to content

CI: Fix failure #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: next
Choose a base branch
from
Open

CI: Fix failure #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1986b6a
CI: use zephyr's checkpatch.pl
soburi Aug 23, 2025
0591681
CI: update board name
soburi Aug 23, 2025
d703b68
CI: use existing manifest
soburi Aug 23, 2025
dc0ae3a
CI: add cmsis_6
soburi Aug 23, 2025
e5e1491
CI: update license_check
soburi Aug 24, 2025
eb778d1
samples: get the variant name from the Zephyr build system
soburi Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,28 @@ jobs:
path: Arduino-Zephyr-API

- name: Initialize
working-directory: Arduino-Zephyr-API
run: |
west init -m https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core.git
west init -l Arduino-Zephyr-API/
west update
git clone https://github.com/arduino/ArduinoCore-API.git ArduinoCore-API
cp -r ArduinoCore-API/api modules/lib/Arduino-Zephyr-API/cores/arduino/.
mkdir -p modules/lib
ln -s Arduino-Zephyr-API modules/lib/
cp -rfp ArduinoCore-API/api Arduino-Zephyr-API/cores/arduino/

- name: Build fade
working-directory: Arduino-Zephyr-API
run: |
west build -p -b arduino_nano_33_ble_sense samples/fade
west build -p -b arduino_nano_33_ble/nrf52840/sense samples/fade

- name: Build i2cdemo
working-directory: Arduino-Zephyr-API
run: |
west build -p -b arduino_nano_33_ble_sense samples/i2cdemo
west build -p -b arduino_nano_33_ble/nrf52840/sense samples/i2cdemo

- name: Build adc
working-directory: Arduino-Zephyr-API
run: |
west build -p -b beagleconnect_freedom samples/analog_input
west build -p -b beagleconnect_freedom/cc1352p7 samples/analog_input

- name: Archive firmware
uses: actions/upload-artifact@v4
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/checkpatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Calculate PR commits + 1'
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 1 ))" >> $GITHUB_ENV
run: |
echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 1 ))" >> $GITHUB_ENV
wget https://raw.githubusercontent.com/zephyrproject-rtos/zephyr/refs/heads/main/scripts/checkpatch.pl
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: ${{ env.PR_FETCH_DEPTH }}
- name: Run checkpatch review
uses: webispy/checkpatch-action@v9
env:
CHECKPATCH_COMMAND: perl ./checkpatch.pl

13 changes: 9 additions & 4 deletions .github/workflows/license_check.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the changes to license_check are required?

Copy link
Member Author

@soburi soburi Aug 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github action is stuck with the current version.
It was originally brought over from the Zephyr main body, so I applied the current one.

Updated commit message.

Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,25 @@ name: Scancode

on: [pull_request]

permissions:
contents: read

jobs:
scancode_job:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
name: Scan code for licenses
steps:
- name: Checkout the code
uses: actions/checkout@v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
- name: Scan the code
id: scancode
uses: zephyrproject-rtos/action_scancode@v4
uses: zephyrproject-rtos/action_scancode@23ef91ce31cd4b954366a7b71eea47520da9b380 # v4
with:
directory-to-scan: 'scan/'
- name: Artifact Upload
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: scancode
path: ./artifacts
Expand Down
6 changes: 4 additions & 2 deletions samples/analog_input/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(analog_input)
Expand Down
6 changes: 4 additions & 2 deletions samples/attach_interrupt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(attach_interrupt)
Expand Down
6 changes: 4 additions & 2 deletions samples/blinky_arduino/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(blinky)
Expand Down
8 changes: 5 additions & 3 deletions samples/button_press_led/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(blinky)
project(button_press_led)

target_sources(app PRIVATE src/main.cpp)

Expand Down
6 changes: 4 additions & 2 deletions samples/fade/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(fade)
Expand Down
6 changes: 4 additions & 2 deletions samples/hello_arduino/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(hello_world)
Expand Down
9 changes: 6 additions & 3 deletions samples/i2cdemo/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(blinky)
project(i2cdemo)

target_sources(app PRIVATE src/main.cpp)

zephyr_compile_options(-Wno-unused-variable -Wno-comment)
6 changes: 4 additions & 2 deletions samples/serial_event/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(serial_event)
Expand Down
6 changes: 4 additions & 2 deletions samples/spi_controller/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(spi_controller)
Expand Down
9 changes: 6 additions & 3 deletions samples/threads_arduino/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@

cmake_minimum_required(VERSION 3.20.0)

cmake_path(SET ZephyrBase $ENV{ZEPHYR_BASE})
set(DTC_OVERLAY_FILE ${ZephyrBase}/../modules/lib/Arduino-Zephyr-API/variants/${BOARD}/${BOARD}.overlay)
# get value of NORMALIZED_BOARD_TARGET early
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE} COMPONENTS yaml boards)

set(DTC_OVERLAY_FILE ${CMAKE_CURRENT_LIST_DIR}/../../variants/${NORMALIZED_BOARD_TARGET}/${NORMALIZED_BOARD_TARGET}.overlay)

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(threads)

target_sources(app PRIVATE src/main.cpp)
zephyr_compile_options(-Wno-unused-variable -Wno-comment)

zephyr_compile_options(-Wno-unused-variable -Wno-comment)
0 ...s/arduino_mkrzero/arduino_mkrzero.overlay → ...21g18a/arduino_mkrzero_samd21g18a.overlay
View file
Open in desktop
File renamed without changes.
0 variants/arduino_mkrzero/variant.h → ...ants/arduino_mkrzero_samd21g18a/variant.h
View file
Open in desktop
File renamed without changes.
0 ...o_nano_33_ble/arduino_nano_33_ble.overlay → ...2840/arduino_nano_33_ble_nrf52840.overlay
View file
Open in desktop
File renamed without changes.
0 variants/arduino_nano_33_ble/variant.h → ...ts/arduino_nano_33_ble_nrf52840/variant.h
View file
Open in desktop
File renamed without changes.
0 ...e_sense/arduino_nano_33_ble_sense.overlay → ...rduino_nano_33_ble_nrf52840_sense.overlay
View file
Open in desktop
File renamed without changes.
0 variants/arduino_nano_33_ble_sense/variant.h → ...uino_nano_33_ble_nrf52840_sense/variant.h
View file
Open in desktop
File renamed without changes.
0 ...o_nano_33_iot/arduino_nano_33_iot.overlay → ...8a/arduino_nano_33_iot_samd21g18a.overlay
View file
Open in desktop
File renamed without changes.
0 variants/arduino_nano_33_iot/variant.h → .../arduino_nano_33_iot_samd21g18a/variant.h
View file
Open in desktop
File renamed without changes.
0 ...ect_freedom/beagleconnect_freedom.overlay → ...p7/beagleconnect_freedom_cc1352p7.overlay
View file
Open in desktop
File renamed without changes.
0 variants/beagleconnect_freedom/variant.h → .../beagleconnect_freedom_cc1352p7/variant.h
View file
Open in desktop
File renamed without changes.
0 ...3220sf_launchxl/cc3220sf_launchxl.overlay → ...3220sf/cc3220sf_launchxl_cc3220sf.overlay
View file
Open in desktop
File renamed without changes.
0 variants/cc3220sf_launchxl/variant.h → ...ants/cc3220sf_launchxl_cc3220sf/variant.h
View file
Open in desktop
File renamed without changes.
0 variants/rpi_pico/rpi_pico.overlay → ...s/rpi_pico_rp2040/rpi_pico_rp2040.overlay
View file
Open in desktop
File renamed without changes.
0 variants/rpi_pico/variant.h → variants/rpi_pico_rp2040/variant.h
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ manifest:
import:
name-allowlist:
- cmsis # required by the ARM port
- cmsis_6 # required by the ARM port
- hal_nordic # required by the custom_plank board (Nordic based)
- hal_ti