Skip to content

esp32s3: i2s: add PLL_D2 clock source #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

esp32s3: i2s: add PLL_D2 clock source #470

wants to merge 1 commit into from

Conversation

epc-ake
Copy link

@epc-ake epc-ake commented Aug 7, 2025

Add the option to add PLL_D2 clock source for tx/rx clk of the i2s periphery of the esp32s3.

marekmatej
marekmatej reviewed Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those the only places where adding PLL_D2 can be used? If there are others, would you mind extending your PR to include them please?

@epc-ake
esp32s3: i2s: add PLL_D2 clock source
14e5a9d 
Add the option to add PLL_D2 clock source for tx/rx clk of the i2s periphery of the esp32s3.

Signed-off-by: Armin Kessler <[email protected]>
@epc-ake epc-ake force-pushed the feature/add_PLL_D2_clk_to_i2s branch from a0b92ec to 14e5a9d Compare August 11, 2025 08:15
@epc-ake
Copy link
Author

epc-ake commented Aug 11, 2025

Are those the only places where adding PLL_D2 can be used? If there are others, would you mind extending your PR to include them please?

What do you mean with other places? Regarding I2S I think this covers it all.
The PLL_DC is also used in LCD_CAM and SAR_ADC:
I think both of them implement the PLL_D2 already.
SAR_ADC:
clk_tree_defs.h
adc_ll.h

LCD_CAM:
clk_tree_defs.h
cam_ll.h
lcd_ll.h

@marekmatej
Copy link
Collaborator

Are those the only places where adding PLL_D2 can be used? If there are others, would you mind extending your PR to include them please?

What do you mean with other places? Regarding I2S I think this covers it all. The PLL_DC is also used in LCD_CAM and SAR_ADC: I think both of them implement the PLL_D2 already. SAR_ADC: clk_tree_defs.h adc_ll.h

LCD_CAM: clk_tree_defs.h cam_ll.h lcd_ll.h

Yes, I meant the other subsystems and drivers. It seems only I2S was missing this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekmatej marekmatej marekmatej approved these changes

@sylvioalves sylvioalves sylvioalves approved these changes

@LucasTambor LucasTambor Awaiting requested review from LucasTambor LucasTambor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epc-ake @marekmatej @sylvioalves