dts: convert pinctrl dtsi files to header files #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinctrl dtsi files must be converted to header files for use with pin groups. Replace all pinctrl dtsi files with header files containing equivalent definitions. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
requested review from
dleach02,
henrikbrixandersen and
mmahadevan108
gmarull
approved these changes
Mar 1, 2022
Comment on lines
+12
to
+15
| #define KINETIS_MUX(port, pin, mux) \ | ||
| (((((port) - 'A') & 0xF) << 28) | \ | ||
| (((pin) & 0x3F) << 22) | \ | ||
| (((mux) & 0x7) << 8)) |
Member
There was a problem hiding this comment.
nit: you could probably have a common non-autogenerated header for this one
|
@dleach02 @mmahadevan108 this is blocking zephyrproject-rtos/zephyr#43033, which @gmarull has approved now, so can you please take a look here so we can merge this? |
mmahadevan108
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinctrl dtsi files must be converted to header files for use with pin
groups. Replace all pinctrl dtsi files with header files containing
equivalent definitions.