Skip to content

Fix offset values for PMIC I2C in the pinctrl generation script. #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −14
Open

Fix offset values for PMIC I2C in the pinctrl generation script. #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17fdd14
mcux: scripts: pinctrl: Updated Offset value for PMIC I2C
EmilioCBen Aug 7, 2025
d0a9971
dts: nxp: nxp_imx: rt: Updated offset values for PMIC I2C
EmilioCBen Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dts/nxp/nxp_imx/rt/MIMXRT735SGAWAR-pinctrl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(((offset) & 0xFFF) << 20) | \
(((mux) & 0xF) << 0))

#define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you rerun the script or was this manually fixed?

#define PMIC_I2C_SCL IOPCTL_MUX(1, 96, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 97, 0) /* PIO0_0 */
#define CTIMER0_CAPTURE0_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE1_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE2_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
Expand Down
4 changes: 2 additions & 2 deletions dts/nxp/nxp_imx/rt/MIMXRT735SGFOA-pinctrl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(((offset) & 0xFFF) << 20) | \
(((mux) & 0xF) << 0))

#define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */
#define PMIC_I2C_SCL IOPCTL_MUX(1, 96, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 97, 0) /* PIO0_0 */
#define CTIMER0_CAPTURE0_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE1_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE2_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
Expand Down
4 changes: 2 additions & 2 deletions dts/nxp/nxp_imx/rt/MIMXRT758SGAWAR-pinctrl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(((offset) & 0xFFF) << 20) | \
(((mux) & 0xF) << 0))

#define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */
#define PMIC_I2C_SCL IOPCTL_MUX(1, 96, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 97, 0) /* PIO0_0 */
#define CTIMER0_CAPTURE0_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE1_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE2_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
Expand Down
4 changes: 2 additions & 2 deletions dts/nxp/nxp_imx/rt/MIMXRT758SGFOA-pinctrl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(((offset) & 0xFFF) << 20) | \
(((mux) & 0xF) << 0))

#define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */
#define PMIC_I2C_SCL IOPCTL_MUX(1, 96, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 97, 0) /* PIO0_0 */
#define CTIMER0_CAPTURE0_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE1_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE2_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
Expand Down
4 changes: 2 additions & 2 deletions dts/nxp/nxp_imx/rt/MIMXRT798SGAWAR-pinctrl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(((offset) & 0xFFF) << 20) | \
(((mux) & 0xF) << 0))

#define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */
#define PMIC_I2C_SCL IOPCTL_MUX(1, 96, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 97, 0) /* PIO0_0 */
#define CTIMER0_CAPTURE0_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE1_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE2_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
Expand Down
4 changes: 2 additions & 2 deletions dts/nxp/nxp_imx/rt/MIMXRT798SGFOA-pinctrl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
(((offset) & 0xFFF) << 20) | \
(((mux) & 0xF) << 0))

#define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */
#define PMIC_I2C_SCL IOPCTL_MUX(1, 96, 0) /* PIO0_0 */
#define PMIC_I2C_SDA IOPCTL_MUX(1, 97, 0) /* PIO0_0 */
#define CTIMER0_CAPTURE0_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE1_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
#define CTIMER0_CAPTURE2_PIO0_0 IOPCTL_MUX(0, 0, 4) /* PIO0_0 */
Expand Down
4 changes: 2 additions & 2 deletions mcux/scripts/pinctrl/lpc/lpc_cfg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,11 @@ def __init__(self, connection, imx_rt = ''):
self._mux = 0
elif self._name == 'PMIC_I2C_SCL' and imx_rt == "MIMXRT7XX":
self._index = 1
self._offset = 0x96
self._offset = 0x60
self._mux = 0
elif self._name == 'PMIC_I2C_SDA' and imx_rt == "MIMXRT7XX":
self._index = 1
self._offset = 0x97
self._offset = 0x61
self._mux = 0
if re.match(r'^\d', self._name):
# If string starts with a digit, it will not be a valid C name
Expand Down