rw612: Fix SCTIMER offset overflow in pinctrl definitions #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SCTIMER_IN/OUT_CLR offset fields were using only 3 bits (max value 7), but some GPIO pins require SCTIMER offsets 8 and 9, causing truncation and incorrect pin configuration.
mmahadevan108
requested review from
EmilioCBen,
decsny,
dleach02 and
mmahadevan108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not really meant to be merged, as the edited file starts with a note that it was generated by "parse_iomux.py". I couldn't find it anywhere. I would have created just an Issue, but this repo doesn't have them enabled.
The problem: SCTIMER_IN/OUT_CLR offset fields are using only 3 bits (max value 7), but some GPIO pins require
SCTIMER offsets 8 and 9, causing truncation and incorrect pin configuration.
To fix this, one extra bit needs to be allocated for the offset fields (as in this PR). Similar change needs to be done in Zephyr's
soc/nxp/rw/pinctrl_defs.h.Feel free to tell me if there is a way I can contribute those changes properly.