hal: renesas: rz: Add ADC support for RZ/A, T, N, V series #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhutnguyenkc
force-pushed
the
rz_support_adc
branch
from
287c762 to
a6b81d3
Compare
nhutnguyenkc
force-pushed
the
rz_support_adc
branch
from
a6b81d3 to
764aeac
Compare
KhiemNguyenT
requested review from
binhnguyen2434,
KhiemNguyenT,
thaoluonguw and
duynguyenxa
duynguyenxa
reviewed
Aug 12, 2025
drivers/rz/README
Outdated
Comment on lines
62
to
77
| * Rename adc_scan_end_isr to adc_c_scan_end_isr. | ||
| Rename g_adc_on_adc to g_adc_on_adc_c with _c suffix. | ||
| Impacted files: | ||
| drivers/rz/fsp/src/rza/r_adc_c/r_adc_c.c | ||
| drivers/rz/fsp/inc/instances/rza/r_adc_c.h |
There was a problem hiding this comment.
@nhutnguyenkc , I think it would be better to also describe the background of the change here, and also separate the commit of modifying this, so that later maintenance for these files are easier
There was a problem hiding this comment.
@duynguyenxa , I added the reason behind the renaming. The main benefit is to make the Zephyr RZ ADC driver to generic for both ADC and ADC_C.
I also added a separate commit for the renaming.
nhutnguyenkc
force-pushed
the
rz_support_adc
branch
2 times, most recently
from
738a804 to
672299c
Compare
Add HAL FSP ADC files for RZ/A series Signed-off-by: Phuc Pham <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Rename adc_scan_end_isr, g_adc_on_adc to adc_c_scan_end_isr, g_adc_on_adc_c with _c suffix respectively to match with ADC_C FSP driver and make the Zephyr RZ ADC driver generic Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP ADC files for RZ/T series Signed-off-by: Phuc Pham <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP ADC files for RZ/N series Signed-off-by: Phuc Pham <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP ADC files for RZ/V series Signed-off-by: Phuc Pham <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
Rename g_adc_on_adc to g_adc_on_adc_c with _c suffix Signed-off-by: Nhut Nguyen <[email protected]>
nhutnguyenkc
force-pushed
the
rz_support_adc
branch
from
672299c to
2bb5adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HAL FSP ADC files for RZ/A, T, N, V series