Skip to content

Conversation

quytranpzz
Copy link
Contributor

@quytranpzz quytranpzz commented Jul 23, 2025

Comment on lines 42 to 43
#include "r_bsp_cpu.h"
#include "mcu_clocks.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quytranpzz: It seems that lacked of include for r_bsp_locking.h?

Comment on lines +48 to +50
#include "mcu/rx26t/mcu_mapped_interrupts_private.h"
#include "mcu/rx26t/mcu_mapped_interrupts.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quytranpzz : Why we need full path for these includes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the above lines to use full-path includes as here, for consistency with FIT and other MCUs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect DISCLAIMER.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the mistake, I have updated this file into latest version to correct the disclaimer.

#endif

/* Set PLL Multiplier. */
SYSTEM.PLLCR.BIT.STC = ((uint8_t)((float)BSP_CFG_PLL_MUL * 2.0f)) - 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different from RDPv1.47. Please separate your update for Zephyr into one commit and record it in the readme file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seperated it in another commit for this change. Thanks you

error = (((float)pclk / ((baud * divisor) * tmp)) - 1) * 100;
abs_error = (error < 0) ? (-error) : error;

if ((abs_error <= 1.0f) || (SCI_MODE_ASYNC != hdl->mode))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different from RDPv1.47.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seperated it in another commit for this change. Thanks you

Hau Ho and others added 2 commits August 18, 2025 07:42
Add HAL support for RX26T using RDP

Signed-off-by: Hau Ho <[email protected]>
Signed-off-by: Phi Tran <[email protected]>
Fix the implicit conversion from float to double warnings
in RX26T source files

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz quytranpzz force-pushed the rx_zephyr_support_soc_rx26t branch from bfa3135 to b5e59be Compare August 18, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants