Skip to content

hal: renesas: rz: Add I2C support for RZ/A, T, N, V series #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025

Conversation

nhutnguyenkc
Copy link
Contributor

Add HAL FSP I2C files for RZ/A, T, N, V series

Copy link

@binhnguyen2434 binhnguyen2434 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KhiemNguyenT KhiemNguyenT self-requested a review July 31, 2025 07:16
fsp/src/${SOC_SERIES_PREFIX}/r_iic_master/r_iic_master.c)
endif()

zephyr_library_sources_ifdef(CONFIG_USE_RZ_FSP_IIC_MASTER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r_iic_master.c is duplicated with above. Please correct it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I remove the duplicate. Please help me check again

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm no problem


#define RIIC_MASTER_CFG_PARAM_CHECKING_ENABLE (BSP_CFG_PARAM_CHECKING_ENABLE)
#define RIIC_MASTER_CFG_DMAC_ENABLE (0)
#define RIIC_MASTER_CFG_ADDR_MODE_10_BIT_ENABLE (0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhutnguyenkc , RZ Zephyr i2c driver doesn't support 10-bit address transfer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duynguyenxa yes, it has been already supported. I have enabled 10-bit addressing mode and already passed i2c test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 10bit-addressing in Zephyr driver API is an option from API argument for user to pass into the API so in order to support it, I think we should always enable this CFG in FSP right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, if you disable this RIIC_MASTER_CFG_ADDR_MODE_10_BIT_ENABLE here, FSP API cannot send the 10-bit address, when user set it in Zephyr API, it will not have any affect

Phuc Pham added 4 commits August 12, 2025 11:35
Add HAL FSP I2C files for RZ/A series

Signed-off-by: Phuc Pham <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP I2C files for RZ/T series

Signed-off-by: Phuc Pham <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP I2C files for RZ/N series

Signed-off-by: Phuc Pham <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
Add HAL FSP I2C files for RZ/V series

Signed-off-by: Phuc Pham <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
@KhiemNguyenT KhiemNguyenT merged commit ad1ae61 into zephyrproject-rtos:main Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants