Skip to content

Conversation

HoZHel
Copy link
Collaborator

@HoZHel HoZHel commented Oct 10, 2024

Provide BLE controller implementation for STM32WB0x SOCs.

Provide the required license (ST ULTIMATE LIBERTY) to use the binary BLOB.

Modify the yaml file to support fetching the STM32WB0 binary stack library
for Bluetooth implementation.

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A README file summing up the origin of the files added would be required.
Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.

Also, to simplify follow up maintenance, I'd expect these files could be updated automatically using existing script. This is not a blocker, but it would be required to have it eventually.

@erwango erwango requested review from FRASTM and gautierg-st October 10, 2024 11:44
@HoZHel
Copy link
Collaborator Author

HoZHel commented Oct 11, 2024

A README file summing up the origin of the files added would be required. Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.

Ok, I'll add it.

Also, to simplify follow up maintenance, I'd expect these files could be updated automatically using existing script. This is not a blocker, but it would be required to have it eventually.

I will update this file in the future.

@HoZHel
Copy link
Collaborator Author

HoZHel commented Oct 16, 2024

A README file summing up the origin of the files added would be required. Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.

Done.

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CMake clean up.
So more comments on the files extracted from the lib to here. Are they all required ?

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
One minor change and we're good to go.

Provide the required license (ST ULTIMATE LIBERTY) to use the binary BLOB.

Modify the yaml file to support fetching the STM32WB0 binary stack library
for Bluetooth implementation.

Signed-off-by: Ali Hozhabri <[email protected]>
Provide BLE controller implementation for STM32WB0x SOCs.

Signed-off-by: Ali Hozhabri <[email protected]>
Add dedicated CMakeLists.txt for STM32WB and STM32WBA to have consistency
with STM32WB0 approach.

Signed-off-by: Ali Hozhabri <[email protected]>
@HoZHel
Copy link
Collaborator Author

HoZHel commented Nov 22, 2024

Rebased
Removed trailing white spaces
dos2unix applied

@erwango erwango merged commit d5fb525 into zephyrproject-rtos:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants