-
Notifications
You must be signed in to change notification settings - Fork 146
Handle gen script rendering template exception and correct RTS/CTS pin configuration in DTSI #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de9385e to
6bf3d2d
Compare
mathieuchopstm
suggested changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor commit-related requests:
- please change first regeneration commit's title from
dts: st: regenerate all dtsi filestodts: st: regenerate all dtsi files with latest pindata - remove the skipped files list from
genpinctrlcommit's message- move it to
dts: st: regenerate all dtsi files with latest pindatainstead - with a header likeThe following SoCs are skipped due to incompatibility with genpinctrl: - I would also make the
genpinctrlcommit message more generic, something like:
- move it to
The latest STM32 Open Pin Data revision contains SoC descriptors that
are not handled properly by genpinctrl yet. These files are parsed
properly but trigger an exception during the pinctrl template rendering.
Add exception logic around template rendering so that problematic SoC files
are skipped - with an error message - instead of crashing the script, which
would otherwise prevent regeneration of DTSI for *all* SoCs.
This allows us to keep updating the pinctrl DTSI for supported SoCs
even when new SoCs requiring genpinctrl updates are added to Pin Data.
Otherwise LGTM.
6bf3d2d to
2124d75
Compare
mathieuchopstm
approved these changes
Nov 8, 2024
2124d75 to
d5ca6e3
Compare
|
@GeorgeCGV Would you mind rebasing ? |
The latest STM32 Open Pin Data revision contains SoC descriptors that are not handled properly by genpinctrl yet. These files are parsed properly but trigger an exception during the pinctrl template rendering. Add exception logic around template rendering so that problematic SoC files are skipped - with an error message - instead of crashing the script, which would otherwise prevent regeneration of DTSI for *all* SoCs. This allows us to keep updating the pinctrl DTSI for supported SoCs even when new SoCs requiring genpinctrl updates are added to Pin Data. Co-authored-by: Mathieu Choplain <[email protected]> Signed-off-by: Georgij Cernysiov <[email protected]>
* CTS - remove open-drain * RTS - replace open-drain with push-pull - remove pull-up bias Signed-off-by: Georgij Cernysiov <[email protected]>
Regenerate to get RTS/CTS pin configuration changes using pin open data 3e9ade. Signed-off-by: Georgij Cernysiov <[email protected]>
d5ca6e3 to
b04b28e
Compare
|
@erwango @mathieuchopstm rebased and re-generated with currently used open pin data 3e9ade (removes Generation output: |
mathieuchopstm
approved these changes
Jan 8, 2025
erwango
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
genpinctrl.pyis corrected with a patch proposed by @mathieuchopstm that handles template exceptions raised by the C0 family.The DTSI files are regenerated with pin open data f4ec11, that removes:
stm32wba50keux, modifies others, and adds some new ones.A correction to RTS/CTS serial pins is added:
open-drainopen-drainwithpush-pullpull-upbiasSuch configuration shall support most use cases and provide faster RTS switching.
The DTSI files are regenerated again to include RTS/CTS configuration changes.