Skip to content

Conversation

@GeorgeCGV
Copy link
Contributor

@GeorgeCGV GeorgeCGV commented Nov 8, 2024

The genpinctrl.py is corrected with a patch proposed by @mathieuchopstm that handles template exceptions raised by the C0 family.

The DTSI files are regenerated with pin open data f4ec11, that removes: stm32wba50keux, modifies others, and adds some new ones.

A correction to RTS/CTS serial pins is added:

  • CTS
    • remove open-drain
  • RTS
    • replace open-drain with push-pull
    • remove pull-up bias

Such configuration shall support most use cases and provide faster RTS switching.

The DTSI files are regenerated again to include RTS/CTS configuration changes.

@GeorgeCGV GeorgeCGV force-pushed the dtsi_corrections branch 2 times, most recently from de9385e to 6bf3d2d Compare November 8, 2024 11:42
Copy link

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor commit-related requests:

  • please change first regeneration commit's title from dts: st: regenerate all dtsi files to dts: st: regenerate all dtsi files with latest pindata
  • remove the skipped files list from genpinctrl commit's message
    • move it to dts: st: regenerate all dtsi files with latest pindata instead - with a header like The following SoCs are skipped due to incompatibility with genpinctrl:
    • I would also make the genpinctrl commit message more generic, something like:
The latest STM32 Open Pin Data revision contains SoC descriptors that
are not handled properly by genpinctrl yet. These files are parsed
properly but trigger an exception during the pinctrl template rendering.

Add exception logic around template rendering so that problematic SoC files
are skipped - with an error message - instead of crashing the script, which
would otherwise prevent regeneration of DTSI for *all* SoCs.

This allows us to keep updating the pinctrl DTSI for supported SoCs
even when new SoCs requiring genpinctrl updates are added to Pin Data.

Otherwise LGTM.

@erwango
Copy link
Member

erwango commented Jan 6, 2025

@GeorgeCGV Would you mind rebasing ?

GeorgeCGV and others added 3 commits January 8, 2025 08:48
The latest STM32 Open Pin Data revision contains SoC descriptors that
are not handled properly by genpinctrl yet. These files are parsed
properly but trigger an exception during the pinctrl template rendering.

Add exception logic around template rendering so that problematic SoC files
are skipped - with an error message - instead of crashing the script, which
would otherwise prevent regeneration of DTSI for *all* SoCs.

This allows us to keep updating the pinctrl DTSI for supported SoCs
even when new SoCs requiring genpinctrl updates are added to Pin Data.

Co-authored-by: Mathieu Choplain <[email protected]>
Signed-off-by: Georgij Cernysiov <[email protected]>
* CTS
   - remove open-drain
* RTS
   - replace open-drain with push-pull
   - remove pull-up bias

Signed-off-by: Georgij Cernysiov <[email protected]>
Regenerate to get RTS/CTS pin configuration changes using
pin open data 3e9ade.

Signed-off-by: Georgij Cernysiov <[email protected]>
@GeorgeCGV
Copy link
Contributor Author

@erwango @mathieuchopstm rebased and re-generated with currently used open pin data 3e9ade (removes stm32wba50keux).

Generation output:

Unexpected AF format: GPIO_AF2_rf (ip: STM32WL33_gpio_v1_0)
Skipping unsupported family STM32MP2.
Skipping unsupported family STM32N6.
Skipping unsupported family STM32U3.
Skipping unsupported family STM32WL3.

@GeorgeCGV GeorgeCGV changed the title Bring DTSI to the latest state and correct RTS/CTS pin configuration DTSI: correct RTS/CTS pin configuration Jan 8, 2025
@GeorgeCGV GeorgeCGV changed the title DTSI: correct RTS/CTS pin configuration Handle gen script rendering template exception and correct RTS/CTS pin configuration in DTSI Jan 8, 2025
@erwango erwango merged commit df06cb7 into zephyrproject-rtos:main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants