Skip to content

Add SWD pinmux to stm32f1 family #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add SWD pinmux to stm32f1 family #247

merged 2 commits into from
Dec 17, 2024

Conversation

@alteman
Copy link

@alteman alteman commented Dec 13, 2024

Add missing SWD pinmux definitions for STM32F1 MCU family

@alteman alteman mentioned this pull request Dec 13, 2024
Closed
gautierg-st
gautierg-st requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@gautierg-st gautierg-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also regenerate the pinctrl.dtsi so that the SWD pins are included in them (that also verifies that the regex is good).

scripts/genpinctrl/stm32f1-pinctrl-config.yaml Outdated
Comment on lines 259 to 262
- name: JTAG PORT
match: ^(SYS|DEBUG)_((JTMS-)?SWDIO|(JTCK-)?SWCLK|JTDI|JTDO(-TRACESWO|-SWO)?|(NJ)?JTRST)$
mode: alternate

Copy link
Collaborator

@gautierg-st gautierg-st Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Move it just after I2S to keep alphabetical order

@alteman
Copy link
Author

alteman commented Dec 16, 2024

  • Moved the section to follow I2S
  • Regenerated the .dtsi files as a separate commit
  • Rebased onto current main/HEAD (3784237)

On an unrelated note: mcu/STM32WBA50KEUx.xml has been deleted from STM32_open_pin_data in commit f4ec11f00e762e37ffc4020f6d4f20d225bc061d (STM32CubeMX 6.12.0), but dts/st/wba/stm32wba50keux-pinctrl.dtsi is still alive in this repo. Not sure if that's by design.

@erwango
Copy link
Member

erwango commented Dec 17, 2024

On an unrelated note: mcu/STM32WBA50KEUx.xml has been deleted from STM32_open_pin_data in commit f4ec11f00e762e37ffc4020f6d4f20d225bc061d (STM32CubeMX 6.12.0), but dts/st/wba/stm32wba50keux-pinctrl.dtsi is still alive in this repo. Not sure if that's by design.

@benothmn-st Do you have any info around this ?

@erwango erwango merged commit d2a1f86 into zephyrproject-rtos:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@gautierg-st gautierg-st gautierg-st approved these changes

@FRASTM FRASTM Awaiting requested review from FRASTM

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alteman @erwango @gautierg-st