Skip to content

Conversation

@benothmn-st
Copy link
Collaborator

Remove all the unused source code that was implemented in zephyr repo

Remove all the unused source code that was implemented in zephyr repo

Signed-off-by: Nidhal BEN OTHMEN <[email protected]>
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with clean up, but I have 2 questions around it

  • how do we ensure that this code won't be overwritten at next Cube update ?
  • We have the same unused code on WB0, do you plan to make similar clean up ? Or is it a different use case

In any case, please update README, so that we know the diif to be maintained at next cube update if update script fails

@benothmn-st
Copy link
Collaborator Author

I'm fine with clean up, but I have 2 questions around it

  • how do we ensure that this code won't be overwritten at next Cube update ?
  • We have the same unused code on WB0, do you plan to make similar clean up ? Or is it a different use case

In any case, please update README, so that we know the diif to be maintained at next cube update if update script fails

Hi Erwan,

With Alessandro, we agree to keep the code as it is actually. So, the comparison with the Cube FW still easy to do.
We will add in the next PR of Cube FW update a comment (in the first #ifndef ZEPHYR) to mention that all those functions that are not compiled here are redefined in the zephyr repo and we will mention the file as reference.
If you agree with this proposition, you can close the PR.

Thanks!

@erwango
Copy link
Member

erwango commented Jan 23, 2025

With Alessandro, we agree to keep the code as it is actually. So, the comparison with the Cube FW still easy to do.
We will add in the next PR of Cube FW update a comment (in the first #ifndef ZEPHYR) to mention that all those functions that are not compiled here are redefined in the zephyr repo and we will mention the file as reference.
If you agree with this proposition, you can close the PR.

I'm fine with this proposal. Thanks
I'm closing the PR then.

@erwango erwango closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants