lib/stm32: stm32wba: radio temperature calibration activation #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested changes
Jun 9, 2025
asm5878
approved these changes
Jun 18, 2025
erwango
reviewed
Jun 18, 2025
lib/stm32wba/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| # Setting the right Cube define according to the Zephyr configuration | ||
| if(NOT CONFIG_BT_STM32WBA_USE_TEMPERATURE_BASED_RADIO_CALIBRATION STREQUAL "y") |
There was a problem hiding this comment.
Please add a Zephyr PR to add the definition of this new symbol and points to this PR (through west.yml update)
There was a problem hiding this comment.
The Zephyr PR has been created : zephyrproject-rtos/zephyr#91898
benothmn-st
approved these changes
Jun 20, 2025
erwango
requested changes
Jun 25, 2025
Comment on lines
63
to
66
| # Setting the right Cube define according to the Zephyr configuration | ||
| if(NOT CONFIG_BT_STM32WBA_USE_TEMPERATURE_BASED_RADIO_CALIBRATION STREQUAL "y") | ||
| zephyr_compile_definitions( -DUSE_TEMPERATURE_BASED_RADIO_CALIBRATION=0 ) | ||
| endif() |
There was a problem hiding this comment.
Nit: IMO, the default should be 0 and we should set =1 only if Kconfig is enabled.
Also - but I may be wrong on that - I think this should be simply:
if (NOT CONFIG_BT_STM32WBA_USE_TEMPERATURE_BASED_RADIO_CALIBRATION)
Add the possibility to change the activation of the temperature calibration of the radio directly from a Kconfig Signed-off-by: Romain Jayles <[email protected]>
The temperature calibration is now activable, its activation needs to be integrated in the library. Signed-off-by: Romain Jayles <[email protected]>
mathieuchopstm
approved these changes
Jun 26, 2025
erwango
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work on the lib/stm32 allows to activate/deactivate the calibration of the radio based on the temperature sensor.
It can be activated/deactivated by a Zephyr config