Skip to content

dcmipp: allow PIPE_SetConfig when pipe state is READY #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

dcmipp: allow PIPE_SetConfig when pipe state is READY #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions stm32cube/stm32h7rsxx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,13 @@ Patch List:
Impacted file:
stm32cube/stm32h7rsxx/drivers/src/stm32h7rsxx_hal_sdio.c

*Allow usage of HAL_DCMIPP_PIPE_SetConfig when DCMIPP is in READY state
Allow performing PIPE configuration when the DCMIPP device is not only
in RESET and ERROR states but also in READY state. This allow to
reconfigure a DCMIPP pipe between 2 use-cases without having to
call HAL_DCMIPP_DeInit / HAL_DCMIPP_Init.
Impacted file:
stm32cube/stm32h7rsxx/drivers/src/stm32h7rsxx_hal_dcmipp.c
Internal reference: 215688

See release_note.html from STM32Cube
3 changes: 2 additions & 1 deletion stm32cube/stm32h7rsxx/drivers/src/stm32h7rsxx_hal_dcmipp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,8 @@ HAL_StatusTypeDef HAL_DCMIPP_PIPE_SetConfig(DCMIPP_HandleTypeDef *hdcmipp, uint3

if (hdcmipp->State == HAL_DCMIPP_STATE_READY)
{
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) || (pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_READY) || (pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) ||
(pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
{
/* Update the DCMIPP PIPE state */
hdcmipp->PipeState[Pipe] = HAL_DCMIPP_PIPE_STATE_BUSY;
Expand Down
11 changes: 10 additions & 1 deletion stm32cube/stm32mp13xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,13 @@ Patch List:
Impacted files:
drivers/include/Legacy/stm32_hal_legacy.h

See release_note.html from STM32Cube
*Allow usage of HAL_DCMIPP_PIPE_SetConfig when DCMIPP is in READY state
Allow performing PIPE configuration when the DCMIPP device is not only
in RESET and ERROR states but also in READY state. This allow to
reconfigure a DCMIPP pipe between 2 use-cases without having to
call HAL_DCMIPP_DeInit / HAL_DCMIPP_Init.
Impacted file:
stm32cube/stm32mp13xx/drivers/src/stm32mp13xx_hal_dcmipp.c
Internal reference: 215688

See release_note.html from STM32Cube
3 changes: 2 additions & 1 deletion stm32cube/stm32mp13xx/drivers/src/stm32mp13xx_hal_dcmipp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,8 @@ HAL_StatusTypeDef HAL_DCMIPP_PIPE_Config(DCMIPP_HandleTypeDef *phdcmipp, uint32_

if (phdcmipp->State == HAL_DCMIPP_STATE_READY)
{
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) || \
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_READY) ||
(pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) ||
(pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
{
/* Update the DCMIPP PIPE state */
Expand Down
9 changes: 9 additions & 0 deletions stm32cube/stm32mp2xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,13 @@ Patch List:
- The stm32cube/stm32mp2xx/drivers/src/stm32mp2xx_ll_rcc.c file was modified
for retrieving the clock configuration of the I2C8 peripheral.

*Allow usage of HAL_DCMIPP_PIPE_SetConfig when DCMIPP is in READY state
Allow performing PIPE configuration when the DCMIPP device is not only
in RESET and ERROR states but also in READY state. This allow to
reconfigure a DCMIPP pipe between 2 use-cases without having to
call HAL_DCMIPP_DeInit / HAL_DCMIPP_Init.
Impacted file:
stm32cube/stm32mp2xx/drivers/src/stm32mp2xx_hal_dcmipp.c
Internal reference: 215688

See release_note.html from STM32Cube
3 changes: 2 additions & 1 deletion stm32cube/stm32mp2xx/drivers/src/stm32mp2xx_hal_dcmipp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,8 @@ HAL_StatusTypeDef HAL_DCMIPP_PIPE_SetConfig(DCMIPP_HandleTypeDef *hdcmipp, uint3

if (hdcmipp->State == HAL_DCMIPP_STATE_READY)
{
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) || (pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_READY) || (pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) ||
(pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
{
/* Update the DCMIPP PIPE state */
hdcmipp->PipeState[Pipe] = HAL_DCMIPP_PIPE_STATE_BUSY;
Expand Down
9 changes: 9 additions & 0 deletions stm32cube/stm32n6xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,13 @@ Patch List:
Impacted file:
stm32cube/stm32n6xx/drivers/src/stm32n6xx_hal_sdio.c

*Allow usage of HAL_DCMIPP_PIPE_SetConfig when DCMIPP is in READY state
Allow performing PIPE configuration when the DCMIPP device is not only
in RESET and ERROR states but also in READY state. This allow to
reconfigure a DCMIPP pipe between 2 use-cases without having to
call HAL_DCMIPP_DeInit / HAL_DCMIPP_Init.
Impacted file:
stm32cube/stm32n6xx/drivers/src/stm32n6xx_hal_dcmipp.c
Internal reference: 215688

See release_note.html from STM32Cube
3 changes: 2 additions & 1 deletion stm32cube/stm32n6xx/drivers/src/stm32n6xx_hal_dcmipp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,8 @@ HAL_StatusTypeDef HAL_DCMIPP_PIPE_SetConfig(DCMIPP_HandleTypeDef *hdcmipp, uint3

if (hdcmipp->State == HAL_DCMIPP_STATE_READY)
{
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) || (pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
if ((pipe_state == HAL_DCMIPP_PIPE_STATE_READY) || (pipe_state == HAL_DCMIPP_PIPE_STATE_RESET) ||
(pipe_state == HAL_DCMIPP_PIPE_STATE_ERROR))
{
/* Update the DCMIPP PIPE state */
hdcmipp->PipeState[Pipe] = HAL_DCMIPP_PIPE_STATE_BUSY;
Expand Down