hal_stm32: dts: h7/r/s : add missing eth_mii and eth_rmii signals #306
Conversation
Unlike the STM32N6 and STM32MP2 series, the STM32H7A/B/S series creates ETH_MII and ETH_RMII nodes in the XML file without a digit after ETH. For example: N6 and MP2: ETH1_RMII_TXD0 H7S: ETH_RMII_TXD0 Update the regular expression to handle these cases. Signed-off-by: Fabrice DJIATSA <[email protected]>
add missing ETH_MII and ETH_RMII signals Signed-off-by: Fabrice DJIATSA <[email protected]>
|
@djiatsaf-st Duplicate of #297 ? |
Seems like a duplicate but the difference is (+3,976 −2 ) instead of (+4,505 −3). |
| slew-rate: very-high-speed | ||
|
|
||
| - name: ETH_RMII | ||
| match: "^ETH\\d+_RMII_(?:CRS_DV|REF_CLK|RXD[0-1]|RX_CLK|RX_ER|TX_EN|RX_DV|TXD[0-1]|TX_CLK|TX_EN)$" |
There was a problem hiding this comment.
It seems that CRS_DV|REF_CLK removal is the difference with #306 (comment), which appears to be right in this regard.
However, I do prefer conciseness of this version.
@mariopaja If you have free cycles, can you adapt your PR to this style ?
Otherwise, we'll wait @djiatsaf-st is back from holidays to fix this.
There was a problem hiding this comment.
@erwango then should I remove CRS_DV|REF_CLK from all affected series?
There was a problem hiding this comment.
No, I mean these should be present and you're PR is right in that regard.
But, I'd prefer you could adopt the same conciseness and keeping the 2 filters instead of adding 2 more.
|
Replaced by #297 |
4 participants
This PR updates the h7r/s-pinctrl.dtsi by adding missing
eth_miiandeth_rmiisignals.fixes issue zephyrproject-rtos/zephyr#94268