Add missing aliases for FSMC#334
Open
Archerist wants to merge 2 commits intozephyrproject-rtos:mainfrom
Open
Conversation
Collaborator
mathieuchopstm
left a comment
mathieuchopstm
left a comment
There was a problem hiding this comment.
Please also update the following to depend on CONFIG_USE_STM32_LL_FMC:
stm32cube/stm32f4xx/README
Outdated
Comment on lines
+59
to
+61
| *Add missing aliases for FSMC | ||
| Impacted files: | ||
| drivers/include/stm32f4xx_ll_fsmc.h |
Collaborator
There was a problem hiding this comment.
Small reword + add internal report reference:
Suggested change
| *Add missing aliases for FSMC | |
| Impacted files: | |
| drivers/include/stm32f4xx_ll_fsmc.h | |
| *Add missing FSMC -> FMC compatibility aliases | |
| Impacted files: | |
| drivers/include/stm32f4xx_ll_fsmc.h | |
| ST Internal Reference: 223859 |
Collaborator
mathieuchopstm
left a comment
mathieuchopstm
left a comment
There was a problem hiding this comment.
Also in
hal_stm32/scripts/genpinctrl/stm32-pinctrl-config.yaml
Lines 107 to 110 in 9d05ebd
- - name: FMC
- match: "^FMC_(?:NL|NADV|CLK|NBL[0-3]|A\\d+|D\\d+|NE[1-4]|NOE|NWE|NWAIT|NCE|INT|SDCLK|SDNWE|SDCKE[0-1]|SDNE[0-1]|SDNRAS|SDNCAS|ALE|CLE)$"
+ - name: FMC / FSMC
+ match: "^FS?MC_(?:NL|NADV|CLK|NBL[0-3]|A\\d+|D\\d+|NE[1-4]|NOE|NWE|NWAIT|NCE|INT|SDCLK|SDNWE|SDCKE[0-1]|SDNE[0-1]|SDNRAS|SDNCAS|ALE|CLE)$"
bias: pull-up
slew-rate: very-high-speedthen run genpinctrl.py and commit the changes in a separate commit
erwango
requested changes
Jan 9, 2026
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Thanks for sharing this.
Aside from @mathieuchopstm's comment, please:
- rework commit messages (see Zephyr repo guidelines for this)
- remove commit on pinctrl. Let's do it in a later commit
Add missing aliases from the ll_fsmc.h for Zephyr's memc driver. Signed-off-by: Yunus Çemberci <yunuscemberci@gmail.com>
For new aliases to work ll_fsmc.c needs to be included as well Signed-off-by: Yunus Çemberci <44519052+Archerist@users.noreply.github.com>
erwango
approved these changes
Mar 4, 2026
gautierg-st
reviewed
Mar 6, 2026
| zephyr_library_sources_ifdef(CONFIG_USE_STM32_LL_FMC drivers/src/stm32f4xx_ll_fmc.c) | ||
| zephyr_library_sources_ifdef(CONFIG_USE_STM32_LL_FMPI2C drivers/src/stm32f4xx_ll_fmpi2c.c) | ||
| zephyr_library_sources_ifdef(CONFIG_USE_STM32_LL_FSMC drivers/src/stm32f4xx_ll_fsmc.c) | ||
| zephyr_library_sources_ifdef(CONFIG_USE_STM32_LL_FMC drivers/src/stm32f4xx_ll_fsmc.c) |
Collaborator
There was a problem hiding this comment.
Nitpicking: move this just above FMPI2C to keep alphabetical order.
mathieuchopstm
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zephyr MEMC drivers use these macros and they are missing in the LL_FSMC header, so i added them here.
cc @mathieuchopstm