ext: simplelink: Use monotonic time#25
Open
pavlohamov wants to merge 1 commit intozephyrproject-rtos:masterfrom
Open
ext: simplelink: Use monotonic time#25pavlohamov wants to merge 1 commit intozephyrproject-rtos:masterfrom
pavlohamov wants to merge 1 commit intozephyrproject-rtos:masterfrom
Conversation
Zephyr sem_timedwait uses uptime, thus user must use mothonic time instead of realtime Signed-off-by: Pavlo Hamov <pasha.gamov@gmail.com>
Author
|
@nashif Not sure who is responsible for this repo. Could you be so kind to take a look? |
cfriedt
approved these changes
May 26, 2022
Member
|
@pavlohamov - LGTM. Do you already have a PR to Zephyr's main repository to run this change through CI? If not, can you create one that will exercise this code path? Please prefix it with |
Member
|
@pavlohamov - normally, it's necessary to create a DNM pull request to |
Member
|
@vaishnavachath - I've asked the author to provide the required DNM PR to verify that this works, but there has been no response. I'll leave it up to you to test / merge if you feel it's appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: In case if
derives RTC time system will hang on bootup
Zephyr sem_timedwait uses uptime, thus user must use motonic time instead of realtime.