simplelink_lpf3: Add support for CC2340R5 SoC #55

jpanisbl · 2024-07-26T10:51:10Z

Datasheet: https://www.ti.com/lit/ds/symlink/cc2340r5.pdf
TRM: https://www.ti.com/lit/ug/swcu193/swcu193.pdf

vaishnavachath · 2024-07-27T06:53:44Z

@jpanisbl Thank you for the PR, is there a platform addition pull request already submitted? If yes can you please update the hal_ti to this PR so that CI tests run against this PR? If not you will need to create the platform addition PR also in parallel, if you have test results please do share those as well

bogdanovs · 2024-07-29T08:14:37Z

@jpanisbl Thank you for the PR, is there a platform addition pull request already submitted? If yes can you please update the hal_ti to this PR so that CI tests run against this PR? If not you will need to create the platform addition PR also in parallel, if you have test results please do share those as well

@vaishnavachath We are working on Zephyr PR and will update west.yaml with revision from this PR. I suppose Zephyr draft PR will be sufficient to trigger CI.

kartben · 2024-07-29T08:46:02Z

simplelink_lpf3/source/third_party/ecc/include/ECCSW.h

+ **                      Copyright 2006 -- 2012 (c)  INVIA                     **
+ **                                                                            **
+ **   All rights reserved. Reproduction in whole or part is prohibited         **
+ **      without the written permission of the copyright owner                 **


it's not really clear if this library is open source...

very much sounds like it's not

ya it was kind of rethorical :) but based on the BSD 3-clause header that follows, there is a -small- chance that TI actually owns the rights to re-license so @jpanisbl please clarify :)

Hi. Thank you for the review.
We are going to remove this ECC lib before updating this PR. Some native Zephyr support for ECC will have to be used instead.

jpanisbl · 2024-07-29T16:32:53Z

@jpanisbl Thank you for the PR, is there a platform addition pull request already submitted? If yes can you please update the hal_ti to this PR so that CI tests run against this PR? If not you will need to create the platform addition PR also in parallel, if you have test results please do share those as well

@vaishnavachath We are working on Zephyr PR and will update west.yaml with revision from this PR. I suppose Zephyr draft PR will be sufficient to trigger CI.

Zephyr draft PR created here:
zephyrproject-rtos/zephyr#76441

"Hello World" fail is not surprising: a python package named crc-tool was added to requirements, but is not available upstream yet.

I'll fix the compliance error (d6a51a1546b4a843c15de8b144744e108cf600f7: dts/arm/ti/cc2340r5.dtsi:16: new blank line at EOF) and update the Zephyr draft PR.

SML892 · 2024-08-14T14:11:51Z

simplelink_lpf3/source/ti/devices/cc23x0r5/inc/hw_types.h

+//
+//*****************************************************************************
+// Bit-band access to address x bit number b using word access (32 bit)
+#define HWREGBITW(x, b)                                                       \


The CC23x0 device does not support bit banding. Consider removing this and check this isn't used anywhere.

@SML892 Done by Stoyan -> PR updated.

jpanisbl · 2024-09-16T16:56:01Z

Link to zephyr PR (which is not "draft" any more, it's now submitted for review): zephyrproject-rtos/zephyr#76441

vaishnavachath · 2024-12-02T08:38:20Z

@jpanisbl
Need a README under simplelink_lpf3 directory detailing how these files were generated and how someone can update to a newer SDK , also please add details on what upstream SDK version these sources were generated, see
https://github.com/zephyrproject-rtos/hal_ti/blob/master/simplelink/README

vaishnavachath

Need a README under simplelink_lpf3 directory detailing how these files were generated and how someone can update to a newer SDK , also please add details on what upstream SDK version these sources were generated, see
https://github.com/zephyrproject-rtos/hal_ti/blob/master/simplelink/README

vaishnavachath · 2024-12-02T12:19:37Z

Looking at the commit history, it looks like you have fixes and changes on top of original changes in your repo, this does not contribute much to the commit history in this repo, can you please squash those? Also if the sources are autogenerated from TI SDK sources, will recommend adding this information in commit message/README.

vaishnavachath · 2025-01-13T10:01:48Z

@jpanisbl The PR looks good to me, only few minor comments, if you can fix those that would be great:

There are still commits that fix previous commits introduced in this PR, this does not add any value to the commit history in this repo, so if you can squash those, it is better.
there are multiple authors/commiters in some of those commits, can you add the Signed-off-by from each author?

vaishnavachath · 2025-01-13T10:02:12Z

@fabiobaltieri @kartben , if you have any other comments, please let know.

Add initial lpf3 content to support cc2340r5. Currently, this includes files necessary to support power management and drivers. All files are added seperately from lpf2 content, which introduces a new folder structure in the TI HAL. Signed-off-by: Vebjorn Myklebust <[email protected]> Signed-off-by: Lars Thalian Morstad <[email protected]> Signed-off-by: Stoyan Bogdanov <[email protected]>

…ephyr Ports parts of simplelink's Driver Porting Layer to TI F3 devices on Zephyr. Taking inspiration from already existing DPL features, we allocate kernel objects using slab memory. This means the total number of k_event, k_msgq and k_thread objects is limited by a compile-time configuration. Signed-off-by: Lars Thalian Morstad <[email protected]>

Port MutexP, SemaphoreP, SwiP, and QueueP to LPF3. Add support for interrupts of INT_CPUIRQ4, INT_LRFD_IRQ0 and INT_LRFD_IRQ1 used by the RCL (TI's radio driver for F3 devices). Add AES and ECDH SimpleLink drivers and their dependencies. Signed-off-by: Vebjorn Myklebust <[email protected]> Signed-off-by: Lars Thalian Morstad <[email protected]> Signed-off-by: Min Xu <[email protected]>

Update simplelink lpf3 hal to the simplelink LPF3 SDK version 8.10.00.55. Signed-off-by: Vebjorn Myklebust <[email protected]>

Port RCL (radio control layer), the radio driver for TI F3 devices to Zephyr. This commit includes the source files of RCL, binary images of modem firmwares, and pre-generated radio settings for adc noise and BLE5. NOTE: currently, the radio settings for BLE5 are compiled as part of the driver library by default, which is a workaround for now. TI's BLE Stack controller requires the radio configuration C structs without the PHY abbreviation appended as a suffix. This commit removes the PHY abbreviation by disabling the "use_phy_abbreviation" when generating the radio settings in SmartRF Studio 8. Signed-off-by: Min Xu <[email protected]>

- Add some driverlib files to CMakeLists. - Add CLKCTL driver. - Add VIMS functionality for flash. VIMS function API is needed to enable/disable buffers and check for activity before read/write/erase. - Extend GPIO functionality with GPIOSetConfigDio and GPIOGetConfigDio. - Add UARTEnable. - Add support for DMA mode in ADC driver. Add support to ADC API for DMA Trigger Event Publisher (INT_EVENT2). The ADC module provides four interrupt sources (one for each conversion result storage register) that can be configured to source the DMA trigger. Signed-off-by: Stoyan Bogdanov <[email protected]> Signed-off-by: Julien Panis <[email protected]>

Detail how this directory was generated and how someone can update to a newer SDK. Also add details on what upstream SDK version these sources were generated. Signed-off-by: Vebjorn Myklebust <[email protected]> Signed-off-by: Julien Panis <[email protected]>

jpanisbl changed the title ~~Add support for CC2340R5 SoC~~ simplelink_lpf3: Add support for CC2340R5 SoC Jul 26, 2024

vaishnavachath self-requested a review July 27, 2024 06:54

vaishnavachath self-assigned this Jul 27, 2024

kartben requested changes Jul 29, 2024

View reviewed changes

jpanisbl force-pushed the baylibre/master branch from 28d3837 to cff5359 Compare July 29, 2024 15:07

SML892 reviewed Aug 14, 2024

View reviewed changes

jpanisbl force-pushed the baylibre/master branch from cff5359 to 0c68fb3 Compare August 29, 2024 07:34

jpanisbl requested review from SML892, fabiobaltieri and kartben September 16, 2024 16:54

vaishnavachath requested changes Dec 2, 2024

View reviewed changes

jpanisbl force-pushed the baylibre/master branch from 928aecd to e6c3c03 Compare December 6, 2024 15:33

vaishnavachath approved these changes Jan 13, 2025

View reviewed changes

vmyklebust and others added 7 commits January 14, 2025 11:17

simplelink: update hal to LPF3 SDK 8.10.00.55

8b66188

Update simplelink lpf3 hal to the simplelink LPF3 SDK version 8.10.00.55. Signed-off-by: Vebjorn Myklebust <[email protected]>

jpanisbl force-pushed the baylibre/master branch from e6c3c03 to d1e2ff8 Compare January 14, 2025 10:43

jpanisbl requested a review from vaishnavachath January 14, 2025 10:47

vaishnavachath approved these changes Jan 14, 2025

View reviewed changes

vaishnavachath merged commit 258652a into zephyrproject-rtos:master Jan 14, 2025

jpanisbl deleted the baylibre/master branch October 17, 2025 14:42

simplelink_lpf3: Add support for CC2340R5 SoC #55

simplelink_lpf3: Add support for CC2340R5 SoC #55

Uh oh!

Conversation

jpanisbl commented Jul 26, 2024

Uh oh!

vaishnavachath commented Jul 27, 2024

Uh oh!

bogdanovs commented Jul 29, 2024

Uh oh!

kartben Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

kartben Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

jpanisbl Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

jpanisbl commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SML892 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

jpanisbl Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

jpanisbl commented Sep 16, 2024

Uh oh!

vaishnavachath commented Dec 2, 2024

Uh oh!

vaishnavachath left a comment

Choose a reason for hiding this comment

Uh oh!

vaishnavachath commented Dec 2, 2024

Uh oh!

vaishnavachath commented Jan 13, 2025

Uh oh!

vaishnavachath commented Jan 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jpanisbl commented Jul 29, 2024 •

edited

Loading