Skip to content

Conversation

@valeriosetti
Copy link
Collaborator

This PR is the relevant part of the PR 9448 that was merged in mainline Mbed TLS in LTS branch "mbedtls-3.6". Changes included in this PR will be automatically included in 3.6.3, so by the time Zephyr's Mbed TLS fork repo is bumbed to that official release, this commit MUST be discarded.

This PR introduces the possibility to use static key slot buffers in the PSA core instead of dynamically allocating them when needed. This helps reducing heap memory usage as well as potentially removing heap management ROM code if heap is not used anywhere else in the Zephyr application.

Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the diff with the upstream PR.

This commit takes only relevant changes of PR
Mbed-TLS/mbedtls#9448 that was merged
in upstream Mbed TLS in the LTS branch "mbedtls-3.6".
Since the original PR was made of several commits, but most
of them were only affecting tests cases (not used in Zephyr),
only changes belonging to the "include" and "library" folders
were included here.

== IMPORTANT ==
Changes introduced in this commit will be automatically
part of Mbed TLS release 3.6.3, so by the time Zephyr's
Mbed TLS fork repo is bumbed to that official release,
this commit MUST be discarded.

This commit introduces the possibility to use static key slot
buffers in the PSA core instead of dynamically allocating them
when needed. This helps reducing heap memory usage as well as
potentially removing heap management ROM code if heap is not
used anywhere else in the Zephyr application.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti force-pushed the psa-use-static-key-slots branch from b23fb7f to 3ee1335 Compare October 24, 2024 13:16
@dkalowsk
Copy link

dkalowsk commented Nov 6, 2024

As discussed in the Release meeting today, we want to consider the deprecation of Tinycrypt a release blocker item for 4.0. That would mean Part1, Part2, and the mbedTLS changes would all need to be merged in.

@tomi-font @ithinuel any objection to this course of action? The point was raised that Tinycrypt has been "just about to be deprecated" for 5 years now, but never seems to make it. We'd like to make it happen now.

@tomi-font
Copy link
Collaborator

As discussed in the Release meeting today, we want to consider the deprecation of Tinycrypt a release blocker item for 4.0. That would mean Part1, Part2, and the mbedTLS changes would all need to be merged in.

@tomi-font @ithinuel any objection to this course of action? The point was raised that Tinycrypt has been "just about to be deprecated" for 5 years now, but never seems to make it. We'd like to make it happen now.

No objection. I'm happy we proceed this way.

@valeriosetti
Copy link
Collaborator Author

Since 4.0 is out, can we please wmerge this? In this way I can move zephyrproject-rtos/zephyr#80368 (and zephyrproject-rtos/zephyr#79931 consequently) forward.

@carlescufi carlescufi merged commit 4952e13 into zephyrproject-rtos:zephyr Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants