Skip to content

Conversation

DINESHKUMARK1
Copy link
Contributor

This adds the config and overlay files to enable building the toolchain needed for the acp_6_0 board in Zephyr.

@DINESHKUMARK1
Copy link
Contributor Author

@stephanosio, Could you please review the pull request? There are CI test failures and it seems they are expected as mentioned in
#778 (review)
. Please let me know if anything needs to be taken care from side.

@DINESHKUMARK1 DINESHKUMARK1 marked this pull request as draft September 17, 2024 09:20
@DINESHKUMARK1 DINESHKUMARK1 marked this pull request as ready for review September 17, 2024 09:22
@DINESHKUMARK1
Copy link
Contributor Author

@stephanosio, Could you please review the pull request? Please let me know if anything needs to be taken care from side.

This adds the config and overlay files to enable building
the toolchain needed for the acp_6_0 board in Zephyr.

Signed-off-by: DINESHKUMAR <[email protected]>
@stephanosio
Copy link
Member

@stephanosio, Could you please review the pull request? Please let me know if anything needs to be taken care from side.

@DINESHKUMARK1 I have created and pushed the changes in this PR to the upstream topic-amd_acp_6_0 branch so that the CI workflow changes can be tested.

I have also invited you as a collaborator to this repository, and you should be able to directly push to topic-amd_acp_6_0 branch if you need to make any further changes.

Superseded by #792.

@stephanosio
Copy link
Member

stephanosio commented Sep 19, 2024

@DINESHKUMARK1 I have modified the commit in the topic branch to fix obvious errors in the CI workflow changes; but, it looks like there is more to fix than that:

Error:     ../gnulib/import/wchar.h:747:1: error: expected ',' or '...' before 'pwc'
Error:     /__w/_temp/workspace/build/.build/xtensa-amd_acp_6_0_adsp_zephyr-elf/src/gdb/gdb/../gdbsupport/gdb_vecs.h:27:20: error: 'gdb' was not declared in this scope
Error:     /__w/_temp/workspace/build/.build/xtensa-amd_acp_6_0_adsp_zephyr-elf/src/gdb/gdb/../gdbsupport/gdb_vecs.h:27:48: error: template argument 1 is invalid
Error:     /__w/_temp/workspace/build/.build/xtensa-amd_acp_6_0_adsp_zephyr-elf/src/gdb/gdb/../gdbsupport/gdb_vecs.h:27:48: error: template argument 2 is invalid
...

https://github.com/zephyrproject-rtos/sdk-ng/actions/runs/10944341634/job/30385967408#step:13:345

You can open PRs against the topic-amd_acp_6_0 branch to test out fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants