Skip to content

Conversation

@DatGizmo
Copy link

This fixes 'error: unknown argument: '--config/home/ncs/toolchains/86896046f0/opt/zephyr-sdk/cmake/zephyr/llvm/clang_compiler_rt.cfg

Signed-off-by: Sebastian Wezel [email protected]

This fixes 'error: unknown argument: '--config/home/ncs/toolchains/86896046f0/opt/zephyr-sdk/cmake/zephyr/llvm/clang_compiler_rt.cfg

Signed-off-by: Sebastian Wezel <[email protected]>
@DatGizmo
Copy link
Author

During testing of the 0.18.0-alpha2 toolchaing with clang I encounters following build error.

error: unknown argument: '--config/home/ncs/toolchains/86896046f0/opt/zephyr-sdk/cmake/zephyr/llvm/clang_compiler_rt.cfg

I was able to fix it with this change, but not sure if this is the preferred way of doing it.

@DatGizmo DatGizmo marked this pull request as ready for review February 20, 2025 09:48
@tejlmand
Copy link
Contributor

this is interesting.

Would be nice with some more info on this, because TOOLCHAIN_C_FLAGS / TOOLCHAIN_LD_FLAGS are lists, and therefore each item should have a space between them when expanded.

The fact that this doesn't happen makes me worried because the fix in this PR won't help in a case like:

list(APPEND TOOLCHAIN_C_FLAGS --foo-flag)
list(APPEND TOOLCHAIN_C_FLAGS --bar-flag)

So if each item in the list is not expanded to individual flags then others issues may happen as well.

@DatGizmo
Copy link
Author

After some debugging with @tejlmand we noticed the issue happens in a different place.
Closing this PR

@DatGizmo DatGizmo closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants