xtensa: Add xtensa-amd_acp_7_0_adsp_zephyr-elf #900
Conversation
|
@stephanosio , Could you please review the pull request? . Please let me know if anything needs to be taken care from side. |
|
@nashif ,@dbaluta ,@stephanosio , Could anyone please review the pull request? . Please let me know if anything needs to be taken care from side.Toolchain is not getting generated in CI tests, could you please check. We are blocked to proceed with the development work |
1 similar comment
|
@nashif ,@dbaluta ,@stephanosio , Could anyone please review the pull request? . Please let me know if anything needs to be taken care from side.Toolchain is not getting generated in CI tests, could you please check. We are blocked to proceed with the development work |
|
Gentle reminder. We are blocked to proceed with the development work @nashif ,@stephanosio , Could anyone please review the pull request? . Please let me know if anything needs to be taken care from side. Toolchain is not getting generated in CI tests, could you please check. |
1 similar comment
|
Gentle reminder. We are blocked to proceed with the development work @nashif ,@stephanosio , Could anyone please review the pull request? . Please let me know if anything needs to be taken care from side. Toolchain is not getting generated in CI tests, could you please check. |
.gitmodules
Outdated
| [submodule "gcc"] | ||
| path = gcc | ||
| url = https://github.com/zephyrproject-rtos/gcc.git | ||
| url = https://github.com/Sivasubramanian678/gcc.git |
There was a problem hiding this comment.
you should not be changing the submodule repo, instead, submit a Pr if needed to the gcc tree under the zephyr project and then point to the commit once it is merged.
There was a problem hiding this comment.
We followed the process mentioned in the https://github.com/zephyrproject-rtos/sdk-ng#workflow-to-test-patches-with-zephyr-sdk.
Is there any change in the process?
Do we need to submit the PR for GCC fork or sdk-ng? Do we need to wait for the merge in GCC fork to submit PR in sdk-ng?
Could you please let us know the steps so that we can work accordingly
There was a problem hiding this comment.
Gentle reminder. We followed the process mentioned in the https://github.com/zephyrproject-rtos/sdk-ng#workflow-to-test-patches-with-zephyr-sdk.
Is there any change in the process?
Do we need to submit the PR for GCC fork or sdk-ng? Do we need to wait for the merge in GCC fork to submit PR in sdk-ng?
Could you please let us know the steps so that we can work accordingly
There was a problem hiding this comment.
Gentle reminder. We followed the process mentioned in the https://github.com/zephyrproject-rtos/sdk-ng#workflow-to-test-patches-with-zephyr-sdk.
Is there any change in the process?
Do we need to submit the PR for GCC fork or sdk-ng? Do we need to wait for the merge in GCC fork to submit PR in sdk-ng?
Could you please let us know the steps so that we can work accordingly
There was a problem hiding this comment.
there is no change to this process. This process works when you have a toolchain already in the SDK, not with a new one like here.
Also, you need to update the overlays, picolibc needs an overlay now, your change still does not provide one.
|
there is a conflict that needs to be resolved. |
|
|
||
|
|
||
| #ifdef XTENSA_CONFIG_INSTANTIATE | ||
| XTENSA_CONFIG_INSTANTIATE(rmap,16) |
There was a problem hiding this comment.
please see b7a0a3d for how this should look like, use xtensa_rmap here.
There was a problem hiding this comment.
@nashif Thank you for informing me of the changes that need to be made. I have implemented them on my side. Could you please review the pull request? Let me know if there is anything else that needs to be addressed.
|
you probably want to take this out of draft, I think it is almost there. |
|
Yes now it is opened for review |
|
needs rebase |
This adds the config and overlay files to enable building the toolchain needed for the acp7_0 board in Zephyr. Signed-off-by: Sivasubramanian <[email protected]>
|
@nashif The rebase is complete and it is ready for review. |
|
Please let us know when this toolchain will be included with the latest release? |
2 participants
This adds the config and overlay files to enable building the toolchain needed for the acp7_0 board in Zephyr.