project: die if the --manifest-file argument is not relative #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was found while testing the --topdir pull request in progress. It's valid with or without it. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
- Coverage 85.95% 85.93% -0.03%
==========================================
Files 11 11
Lines 3453 3455 +2
==========================================
+ Hits 2968 2969 +1
- Misses 485 486 +1
|
pdgendt
approved these changes
Jan 17, 2026
Collaborator
pdgendt
left a comment
pdgendt
left a comment
There was a problem hiding this comment.
A test to catch this would be nice.
carlescufi
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found while testing the --topdir pull request #854 in progress. It's valid with or without it.