feat: add --topdir commandline option #913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the enforcement of "supported topologies" (https://docs.zephyrproject.org/latest/develop/west/workspaces.html#topologies-supported) and enables users to have whatever kind of topology they want. This also enables the following workflow: ``` # Clone the project using regular git, just like every other project # in the world. git clone git@github.com:foo/my-project # Build the project using west. west --topdir=./build init --local . cd build west build <target> <etc> ``` This solution also sidesteps the odd restriction that the topdir should be located in `..`, which can result in polluting random locations and makes some CI workflows difficult.
Collaborator
|
Not sure if you noticed #854 |
Author
Thanks! I will wait for that PR to be merged then. In the meantime, I have adopted the solution described in #774 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the enforcement of "supported topologies" (https://docs.zephyrproject.org/latest/develop/west/workspaces.html#topologies-supported) and enables users to have whatever kind of topology they want.
This also enables the following workflow:
This solution also sidesteps the odd restriction that the topdir should be located in
.., which can result in polluting random locations and makes some CI workflows difficult.Known Issues
For some reason, having
manifest.pathset as an absolute path produces a warning. If any maintainers can explain why this is the case, that would be much appreciated.Due to this, the unit test suite is failing.