Remove the GpioToken entirely
#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.88 introduces `unnecessary_transmute` warninigs that are triggered by the bindgen code. Suppress these. Signed-off-by: David Brown <[email protected]>
The gpio driver's 'token' to ensure uniqueness doesn't really help with correctness (as C code can use the gpio device as well). Short of re-defining the gpio interfaces, remove this token entirely, and make only the `get_instance` of gpio unsafe, to indicate that the safety of GPIO operations is dependent on the underlying controller. This should improve the hygeine of the GPIO API significantly, and allow uses, such as waiting on multiple pins, to be possible. Signed-off-by: David Brown <[email protected]>
teburd
approved these changes
Jun 27, 2025
cfriedt
approved these changes
Jun 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the GPIO driver, by removing the token. This relies on the underlying gpio driver being thread safe. Keep the
get_instanceas unsafe, as this can't be determined statically.