zephyr: sys: Create Timer #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3zd3z
force-pushed
the
timer
branch
2 times, most recently
from
9d8e709 to
f3528b3
Compare
cfriedt
approved these changes
Dec 17, 2024
Ablu
approved these changes
Dec 18, 2024
So, I'm not sure the right answer here. When commits are amended, github basically discards the history and it is really hard to tell what was changed, so I tend to add more commits. For new code like this, it probably makes sense to squash the history down after the reviews are done. I'll fix the things you mention, which are pretty minor, and then simplify the history.. |
Avoid generating build warnings about things that look like links in bindgen copied rustdocs. The larger problem is that these are in a different syntax than rustdoc comments, and will not be formatted nicely. Signed-off-by: David Brown <[email protected]>
Add a set of wrappers for Zephyr's timer. Timers start as `StoppedTimer`, which can be either dynamic or static (through object). This can then be started either with `start_simple` or `start_callback` which will return a `SimpleTimer` or a `CallbackTimer`. This can then be turned back into stopped timers with a `stop` method. Signed-off-by: David Brown <[email protected]>
Create a test to exercise the zephyr::timer timers. This uses both SimpleTimer and CallbackTimer intensely for 5 seconds and prints out the results. Signed-off-by: David Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a set of wrappers for Zephyr's timer. Timers start as
StoppedTimer, which can be either dynamic or static (through object). This can then be started either withstart_simpleorstart_callbackwhich will return aSimpleTimeror aCallbackTimer. This can then be turned back into stopped timers with astopmethod.