samples: Properly filter samples by supported Rust targets #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without explicitly declaring the need for Rust support, twister tries to build these samples on targest that don't yet support Rust. Include the filter, as well as an explicit platform allow of the supported targets. Signed-off-by: David Brown <[email protected]>
kartben
approved these changes
Jan 25, 2025
|
Weird - one would think the filter would suffice. |
cfriedt
approved these changes
Jan 25, 2025
Two reasons for the target list. One is that there are a few obscure targets that use an arch we support with Rust, but don't actually work (notably, dynamic clocks prevent it from working). The other is that the filter comes fairly late in the twister process, and it starts these builds and has to run kconfig in order to figure out whether Rust is enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without explicitly declaring the need for Rust support, twister tries to build these samples on targest that don't yet support Rust. Include the filter, as well as an explicit platform allow of the supported targets.