Skip to content

CI: Change doc generation to use a more generic target #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

d3zd3z
Copy link
Collaborator

@d3zd3z d3zd3z commented Feb 4, 2025

Rather than targeting a specific board, use a Qemu target, which should make the docs fairly general. The generated devicetree will be minimal, but users wishing to view these docs should be generating them for a specific build anyway.

@d3zd3z d3zd3z requested review from teburd, cfriedt and ithinuel February 4, 2025 17:51
Fix this to avoid failing doc generation.

Signed-off-by: David Brown <[email protected]>
Rather than targeting a specific board, use a Qemu target, which should
make the docs fairly general. The generated devicetree will be minimal,
but users wishing to view these docs should be generating them for a
specific build anyway.

Signed-off-by: David Brown <[email protected]>
@d3zd3z d3zd3z force-pushed the gendocs-2025-02-04 branch from 20019c1 to 8168496 Compare February 4, 2025 19:32
@teburd
Copy link

teburd commented Feb 4, 2025

typically with rustdoc you'd enable all feature flags, is that sort of thing not possible?

@d3zd3z
Copy link
Collaborator Author

d3zd3z commented Feb 4, 2025

typically with rustdoc you'd enable all feature flags, is that sort of thing not possible?

Well, that's up to the prj.conf in the docgen project. We don't really use features with Zephyr, as they come from Kconfigs.

This should ensure that we get full coverage in the docs.

Signed-off-by: David Brown <[email protected]>
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@d3zd3z d3zd3z merged commit cf3dc6c into main Feb 4, 2025
3 checks passed
@d3zd3z d3zd3z deleted the gendocs-2025-02-04 branch February 4, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants